Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] string conversion for duration types (to_durations, from_durations) #5625

Merged
merged 63 commits into from
Aug 7, 2020
Merged

[REVIEW] string conversion for duration types (to_durations, from_durations) #5625

merged 63 commits into from
Aug 7, 2020

Commits on Jul 2, 2020

  1. add string conversion API from_durations()

    @karthikeyann
    karthikeyann committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    fa3a659 View commit details
    Browse the repository at this point in the history

  2. rename variables, enums

    @karthikeyann
    karthikeyann committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    26f9833 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. support isoformat single digit for H:M:S

    @karthikeyann
    karthikeyann committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    e7c9359 View commit details
    Browse the repository at this point in the history

  2. add durations_tests.cpp

    @karthikeyann
    karthikeyann committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    5b91efb View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. update doc for format specifiers

    @karthikeyann
    karthikeyann committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    7eb218c View commit details
    Browse the repository at this point in the history

  2. skip trailing zero for %f specifier, %u of length 6.

    @karthikeyann
    karthikeyann committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    6a6f23e View commit details
    Browse the repository at this point in the history

  3. update doc duration type, ISO format string

    @karthikeyann
    karthikeyann committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    c372d1e View commit details
    Browse the repository at this point in the history

  4. misc style changes

    @karthikeyann
    karthikeyann committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    9c0ec8f View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. add dot as par of %u, %f subsecond specifier (dot not present if zero)

    @karthikeyann
    karthikeyann committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e2d008a View commit details
    Browse the repository at this point in the history

  2. style fix clang-format

    @karthikeyann
    karthikeyann committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    d61c645 View commit details
    Browse the repository at this point in the history

  3. style fix spacing

    @karthikeyann
    karthikeyann committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    10795ab View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. add nvtx to from_durations, comments update

    @karthikeyann
    karthikeyann committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    907843f View commit details
    Browse the repository at this point in the history

  2. add to_durations

    @karthikeyann
    karthikeyann committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    fc04aa6 View commit details
    Browse the repository at this point in the history

  3. add to_durations unit tests

    @karthikeyann
    karthikeyann committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    7cf538e View commit details
    Browse the repository at this point in the history

  4. style fix clang-format

    @karthikeyann
    karthikeyann committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    8713042 View commit details
    Browse the repository at this point in the history

  5. change log entry for PR rapidsai#5625

    @karthikeyann
    karthikeyann committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    be7ea2d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'branch-0.15' of github.com:rapidsai/cudf into fea-durat… 

    …ions_strings
    @karthikeyann
    karthikeyann committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    d6899fe View commit details
    Browse the repository at this point in the history

  7. remove units from format_compiler

    @karthikeyann
    karthikeyann committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    cb5f473 View commit details
    Browse the repository at this point in the history

  8. stylefix clang-format

    @karthikeyann
    karthikeyann committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    99d92ee View commit details
    Browse the repository at this point in the history

  9. conda recipe header include

    @karthikeyann
    karthikeyann committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    e087ac6 View commit details
    Browse the repository at this point in the history

  10. add duration strings API microseconds unit test

    @karthikeyann
    karthikeyann committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    5bfd55e View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. add converters utilities.cuh

    @karthikeyann
    karthikeyann committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    dc01137 View commit details
    Browse the repository at this point in the history

  2. macros for cudf::test::expect_* column, table for showing line of fai… 

    …lure
    @karthikeyann
    karthikeyann committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    ae02fd8 View commit details
    Browse the repository at this point in the history

  3. add src/strings/convert/utilities.cuh

    @karthikeyann
    karthikeyann committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    6aa6a4d View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: David <45795991+davidwendt@users.noreply.github.com>
    @karthikeyann @davidwendt
    karthikeyann and davidwendt committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    508369b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'branch-0.15' of github.com:rapidsai/cudf into fea-durat… 

    …ions_strings
    @karthikeyann
    karthikeyann committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    530a723 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. Apply suggestions from code review (harrism) 

    Co-authored-by: Mark Harris <mharris@nvidia.com>
    @karthikeyann @harrism
    karthikeyann and harrism committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    c4fd5bd View commit details
    Browse the repository at this point in the history

  2. review comments changes (harrism)

    @karthikeyann
    karthikeyann committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    f639cb8 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. use libcu++ std::chrono methods

    @karthikeyann
    karthikeyann committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    40309f0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-0.15' of github.com:rapidsai/cudf into fea-durat… 

    …ions_strings
    @karthikeyann
    karthikeyann committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    3a13550 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Merge branch 'branch-0.15' of github.com:rapidsai/cudf into fea-durat… 

    …ions_strings
    @karthikeyann
    karthikeyann committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    b658f7d View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. Apply suggestions from code review (davidwendt) 

    Co-authored-by: David <45795991+davidwendt@users.noreply.github.com>
    @karthikeyann @davidwendt
    karthikeyann and davidwendt committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    d573172 View commit details
    Browse the repository at this point in the history

  2. style fix clang-format

    @karthikeyann
    karthikeyann committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    5045f65 View commit details
    Browse the repository at this point in the history

  3. replace device_ptr deref with get_value

    @karthikeyann
    karthikeyann committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    5c5dad7 View commit details
    Browse the repository at this point in the history

  4. use device_uvector for duration format_items

    @karthikeyann
    karthikeyann committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    b7d7cc2 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. change for loop to transform_reduce

    @karthikeyann
    karthikeyann committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    748c95a View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. specifiers to std::format supported spec only

    @karthikeyann
    karthikeyann committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    a1ef104 View commit details
    Browse the repository at this point in the history

  2. remove modulo_time

    @karthikeyann
    karthikeyann committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    5e76e45 View commit details
    Browse the repository at this point in the history

  3. remove countTrailingZeros

    @karthikeyann
    karthikeyann committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    95ff3a6 View commit details
    Browse the repository at this point in the history

  4. change from_durations to std::format compliant

    @karthikeyann
    karthikeyann committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    7cb80a4 View commit details
    Browse the repository at this point in the history

  5. update unit tests to std::format compliant

    @karthikeyann
    karthikeyann committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    55afdc9 View commit details
    Browse the repository at this point in the history

  6. update ISOFormat tests, other tests to be std::format complaint

    @karthikeyann
    karthikeyann committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    6c5a951 View commit details
    Browse the repository at this point in the history

  7. update parsing D,H,M,S to be std::format compliant

    @karthikeyann
    karthikeyann committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    bd1d5c8 View commit details
    Browse the repository at this point in the history

  8. update default format args

    @karthikeyann
    karthikeyann committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    d9ca314 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'branch-0.15' of github.com:rapidsai/cudf into fea-durat… 

    …ions_strings
    @karthikeyann
    karthikeyann committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    6a8b2f1 View commit details
    Browse the repository at this point in the history

  10. add %p%R%T parse support

    @karthikeyann
    karthikeyann committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    0e3bd65 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. remove runtime type_id info, use templates

    @karthikeyann
    karthikeyann committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    a3b2c47 View commit details
    Browse the repository at this point in the history

  2. move powers_of_ten to __constant__ memory (to avoid local memory access)

    @karthikeyann
    karthikeyann committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    ee5bf3d View commit details
    Browse the repository at this point in the history

  3. replace timeparts int32_t array with struct

    @karthikeyann
    karthikeyann committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    2e42c68 View commit details
    Browse the repository at this point in the history

  4. stylefix lowercase struct members

    @karthikeyann
    karthikeyann committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    0def734 View commit details
    Browse the repository at this point in the history

  5. add parse_2digit_int, parse_hour, minute, second

    @karthikeyann
    karthikeyann committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    b7dc79d View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. add benchmark DuratiionsToString, StringToDurations

    @karthikeyann
    karthikeyann committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    b7045f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. optimization of integer to string function

    @karthikeyann
    karthikeyann committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    151fa49 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-0.15' of github.com:rapidsai/cudf into fea-durat… 

    …ions_strings
    @karthikeyann
    karthikeyann committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    05cbb18 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. add parse tests for HMSpRT

    @karthikeyann
    karthikeyann committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    85d0631 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-0.15' of github.com:rapidsai/cudf into fea-durat… 

    …ions_strings
    @karthikeyann
    karthikeyann committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    9f7dcdb View commit details
    Browse the repository at this point in the history

  3. support all escape Characters, add unit tests

    @karthikeyann
    karthikeyann committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    77b518c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-0.15' of github.com:rapidsai/cudf into fea-durat… 

    …ions_strings
    @karthikeyann
    karthikeyann committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    bbbe2ac View commit details
    Browse the repository at this point in the history

  5. review updates (davidwendt)

    @karthikeyann
    karthikeyann committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    1ebfb0a View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. review updates (karthikeyann)

    @karthikeyann
    karthikeyann committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    f37af51 View commit details
    Browse the repository at this point in the history

  2. doc update: locale -> without sign

    @karthikeyann
    karthikeyann committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    0d84102 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. doc update escaping % character

    @karthikeyann
    karthikeyann committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    78f94d8 View commit details
    Browse the repository at this point in the history

  2. change benchmark name

    @karthikeyann
    karthikeyann committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    ef93d42 View commit details
    Browse the repository at this point in the history