-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add filter_characters_of_type strings API #5666
[REVIEW] Add filter_characters_of_type strings API #5666
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.15 #5666 +/- ##
============================================
Coverage 86.25% 86.25%
============================================
Files 72 72
Lines 12672 12676 +4
============================================
+ Hits 10930 10934 +4
Misses 1742 1742
Continue to review full report at Codecov.
|
Do we want to include benchmarks for strings features? |
Argh. I keep forgetting about the benchmarks. I need to create an issue to add these. |
Closes #5520
Create a new strings API that can filter characters from strings by specifying the character types.
Also, allows for an optional replacement character or string in place of each removed character.