-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add dictionary support to cudf::reduce #6666
[REVIEW] Add dictionary support to cudf::reduce #6666
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #6666 +/- ##
============================================
Coverage 81.94% 81.94%
============================================
Files 96 96
Lines 16164 16164
============================================
Hits 13246 13246
Misses 2918 2918 Continue to review full report at Codecov.
|
Some of |
Ok, the last few builds have failed because they timed out (>40 minutes!). Adding dictionary to the simple reduce functions (min, max, sum, sum-of-squares, and product) increase their compile time from ~5 mins to ~18 mins. For now, I've included changes to remove the 2nd type-dispatch call. And the compile time for these files are now ~50 seconds. All tests are passing but benchmarks have not been checked. I will create an issue to discuss these changes and then will likely redo them in a separate PR. |
Created PR #6727 to fix the compile-time issues. Now this PR will become dependent on that one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
Few minor changes.
Reference #5963
This PR adds dictionary column type support to the set of
cudf::reduce
functions.This PR depends on utilities added in PR #6651
Here are the reduce operations that will be included in this PR.