[REVIEW] Add dictionary support to cudf::quantile #6676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #6676 +/- ##
===============================================
+ Coverage 82.21% 82.27% +0.06%
===============================================
Files 94 94
Lines 15478 15539 +61
===============================================
+ Hits 12725 12785 +60
- Misses 2753 2754 +1
Continue to review full report at Codecov.
|
karthikeyann
approved these changes
Nov 6, 2020
… dictionary-quantile
harrism
added
5 - Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #5963
Add support for dictionary column types in
cudf::quantile. This function is also used bycudf::reducein PR #6666.The code change here is simply to dispatch on the dictionary key type and then pass a dictionary-iterator to transform function that computes the quantile values --
select_quantile_data.This means this PR is also dependent on #6651 for the
is_dictionarytrait.Also, added a simple gtest for testing this new dictionary code path.