[REVIEW] Fix columns & index handling in dataframe constructor
#6838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
2 - In Progress
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #6838 +/- ##
===============================================
+ Coverage 81.53% 82.00% +0.46%
===============================================
Files 96 96
Lines 15876 16245 +369
===============================================
+ Hits 12945 13321 +376
+ Misses 2931 2924 -7
Continue to review full report at Codecov.
|
galipremsagar
changed the title
columns & index handling in dataframe constructorcolumns & index handling in dataframe constructor
shwina
reviewed
Nov 24, 2020
shwina
reviewed
Nov 24, 2020
|
At a high level it looks like this shares some logic with Can we find a way to reuse code between the two? |
galipremsagar
changed the title
columns & index handling in dataframe constructorcolumns & index handling in dataframe constructor
galipremsagar
changed the title
columns & index handling in dataframe constructorcolumns & index handling in dataframe constructor
galipremsagar
requested review from
harrism and
codereport
and removed request for
a team,
harrism and
codereport
galipremsagar
changed the title
columns & index handling in dataframe constructorcolumns & index handling in dataframe constructor
galipremsagar
added
3 - Ready for Review
rjzamora
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
The dask_cudf changes seem fine to me. If the map_partitions call could happen on a large graph, I would suggest that we find a way to push the set_index operation into an earlier task. However, this is a single-partition dask_cudf.DataFrame by design, so graph size will never be an issue.
shwina
reviewed
Dec 4, 2020
shwina
reviewed
Dec 4, 2020
kkraus14
added
5 - Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6821
This PR fixes issue where
columnsandindexare currently not being handled correctly in specific scenarios.