Move align_ptr_for_type() from cuda.cuh to alignment.hpp #6859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
davidwendt
added
3 - Ready for Review
harrism
approved these changes
Nov 30, 2020
harrism
added
the
5 - Ready to Merge
raydouglass
approved these changes
Nov 30, 2020
|
Thanks @davidwendt this should help us |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #6859 +/- ##
============================================
Coverage 81.94% 81.94%
============================================
Files 96 96
Lines 16164 16164
============================================
Hits 13246 13246
Misses 2918 2918 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6857
This function contains only C++ STL code and no CUDA code. Also, including it in the
column_device_view.cuhrequired a new dependency oncub/cub.cuh(per thecuda.cuh) as found when building blazingSQL.