Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpuCI] Auto-merge branch-0.17 to branch-0.18 [skip ci] #6879

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

GPUtester
Copy link
Collaborator

Auto-merge triggered by push to branch-0.17 that creates a PR to keep branch-0.18 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

closes #6228
closes #4400 

- [x] added groupby hash mean aggregation. (multi-pass method).
- [x] added multi-pass method (collated second pass)
- [x] enabled MEAN, STD, VARIANCE, ~SUM_OF_SQUARES~
- [x] unit tests

Implemented 2 pass approach for compound aggregations.
compound aggregations are aggregartion which can be computed from results of simple aggregations.
simple aggregations need only 1-pass through the grouped values. 
`aggregation::get_simple_aggregations()` will return simple aggregation for the aggregation. 

- find required simple aggregations for compound aggregations and add to list.
- first pass is calculating the list of simple aggregations. (1 kernel launch)
- second pass takes result of simple aggregations and computes results of compound aggregations. (1 kernel launch)

Authors:
  - Karthikeyan Natarajan <karthikeyann@users.noreply.github.com>
  - Karthikeyan <6488848+karthikeyann@users.noreply.github.com>

Approvers:
  - Devavret Makkar
  - Ashwin Srinath
  - Jake Hemstad

URL: #6392
@GPUtester GPUtester requested review from a team as code owners December 2, 2020 15:27
@GPUtester GPUtester merged commit 48adcc0 into branch-0.18 Dec 2, 2020
@GPUtester
Copy link
Collaborator Author

SUCCESS - Auto-merge complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants