Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rmm_mode=managed parameter for gtests #6912

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

davidwendt
Copy link
Contributor

When using parameter --rmm_mode=managed for gtests Invalid RMM allocation mode: managed exception is thrown.
The logic in include/cudf_test/base_fixture.hpp is just missing a return statement.

@davidwendt davidwendt requested a review from a team as a code owner December 4, 2020 14:13
@davidwendt davidwendt self-assigned this Dec 4, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Dec 4, 2020
@davidwendt davidwendt added this to PR-WIP in v0.18 Release via automation Dec 4, 2020
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Dec 4, 2020
@davidwendt davidwendt moved this from PR-WIP to PR-Needs review in v0.18 Release Dec 4, 2020
@davidwendt davidwendt added the bug Something isn't working label Dec 4, 2020
v0.18 Release automation moved this from PR-Needs review to PR-Reviewer approved Dec 4, 2020
@davidwendt
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #6912 (a155448) into branch-0.18 (e9aedb2) will increase coverage by 0.03%.
The diff coverage is 83.05%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #6912      +/-   ##
===============================================
+ Coverage        81.94%   81.97%   +0.03%     
===============================================
  Files               96       96              
  Lines            16164    16230      +66     
===============================================
+ Hits             13246    13305      +59     
- Misses            2918     2925       +7     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 86.30% <66.66%> (-0.53%) ⬇️
python/cudf/cudf/io/avro.py 78.57% <66.66%> (-3.25%) ⬇️
python/cudf/cudf/io/csv.py 94.00% <66.66%> (-1.75%) ⬇️
python/cudf/cudf/io/json.py 96.55% <66.66%> (-3.45%) ⬇️
python/cudf/cudf/io/orc.py 88.40% <66.66%> (-0.99%) ⬇️
python/cudf/cudf/utils/ioutils.py 78.71% <80.00%> (-1.18%) ⬇️
python/cudf/cudf/core/column/timedelta.py 89.53% <87.50%> (+0.04%) ⬆️
python/cudf/cudf/utils/utils.py 85.35% <94.11%> (+1.10%) ⬆️
python/cudf/cudf/core/column/categorical.py 93.37% <100.00%> (+0.03%) ⬆️
python/cudf/cudf/core/column/datetime.py 88.94% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c8e05f...a155448. Read the comment docs.

@harrism harrism added tests Unit testing for project 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team labels Dec 7, 2020
@rapids-bot rapids-bot bot merged commit 598a14d into rapidsai:branch-0.18 Dec 7, 2020
v0.18 Release automation moved this from PR-Reviewer approved to Done Dec 7, 2020
@davidwendt davidwendt deleted the bug-test-managed-mode branch December 7, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change tests Unit testing for project
Projects
No open projects
v0.18 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants