Fix cudf::merge gtest for dictionary columns #6942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cudf::merge
API expects the key columns to be sorted. This means that if null rows are included, these null entries should all appear either at beginning or at the end of the column depending on the null_order for the sort. TheMergeDictionaryTest.WithNull
gtest placed null rows in the middle of the column. The expected results should also have included null entries at the beginning or the end.This PR also includes an extra test for checking merge results are consistent with the sort parameters
cudf::order
andcudf::null_order
. This test also includes a larger number of rows to ensurethrust::merge
requires more than one tile/block in its runtime logic.