-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow constructing frames from a ColumnAccessor #7298
Conversation
ColumnAccessor ctor
…ix-numpy-style-issues
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7298 +/- ##
===============================================
+ Coverage 82.09% 82.22% +0.12%
===============================================
Files 97 100 +3
Lines 16474 16964 +490
===============================================
+ Hits 13524 13948 +424
- Misses 2950 3016 +66
Continue to review full report at Codecov.
|
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rerun tests |
@gpucibot merge |
1 similar comment
@gpucibot merge |
Constructing a DataFrame from a ColumnAccessor previously had unintended side-effects:
In a discussion with @galipremsagar - we decided that it's probably best not to handle
ColumnAccessor
in the frame constructors.ColumnAccessor
inFrame
constructorsSeries.copy()
andDataFrame.copy()
into a singleFrame.copy()