Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change JNI API to avoid loading native dependencies when creating sort order classes. [skip ci] #7729

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Change JNI API to avoid loading native dependencies when creating sort order classes. [skip ci] #7729

merged 2 commits into from
Mar 25, 2021

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Mar 25, 2021

This is to address an issue we found in the Spark out of core sorting implementation.

@revans2 revans2 added bug Something isn't working Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer breaking Breaking change labels Mar 25, 2021
@revans2 revans2 self-assigned this Mar 25, 2021
@revans2 revans2 requested a review from a team as a code owner March 25, 2021 20:10
@revans2 revans2 changed the title Change JNI API to avoid loading native dependencies when creating sort order classes. Change JNI API to avoid loading native dependencies when creating sort order classes. [skip ci] Mar 25, 2021
@revans2 revans2 mentioned this pull request Mar 25, 2021
Merged
@jlowe jlowe added the Spark Functionality that helps Spark RAPIDS label Mar 25, 2021
jlowe
jlowe approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could avoid breaking compilation with this change if desired, but I'm OK if we don't think it's worth the trouble.

java/src/main/java/ai/rapids/cudf/Table.java Show resolved Hide resolved
@revans2
Copy link
Contributor Author

revans2 commented Mar 25, 2021

rerun tests

@revans2
Copy link
Contributor Author

revans2 commented Mar 25, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b8f149a into rapidsai:branch-0.19 Mar 25, 2021
@revans2 revans2 deleted the fix_jni_table_ordering branch March 25, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@revans2 revans2

Labels
breaking Breaking change bug Something isn't working Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@revans2 @jlowe