Use rmm::device_uvector in place of rmm::device_vector for CSV reader/writer #7805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void-device-vector-csv
…void-device-vector-csv
…void-device-vector-csv
…void-device-vector-csv
vuule
added
libcudf
26 tasks
vuule
commented
Apr 1, 2021
| @@ -180,7 +183,19 @@ std::vector<std::string> setColumnNames(std::vector<char> const &header, | |||
| return col_names; | |||
| } | |||
|
|
|||
| table_with_metadata reader::impl::read(rmm::cuda_stream_view stream) | |||
| template <typename C> | |||
| void erase_except_last(C &container, rmm::cuda_stream_view stream) | |||
There was a problem hiding this comment.
pulled this into a separate function because a device lambda cannot be declared in a private function
|
Added cuIO reviewers. |
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #7805 +/- ##
===============================================
+ Coverage 82.88% 82.94% +0.05%
===============================================
Files 103 103
Lines 17668 17713 +45
===============================================
+ Hits 14645 14692 +47
+ Misses 3023 3021 -2
Continue to review full report at Codecov.
|
harrism
reviewed
Apr 6, 2021
kaatish
reviewed
Apr 6, 2021
devavret
approved these changes
Apr 6, 2021
devavret
reviewed
Apr 6, 2021
…void-device-vector-csv
… into avoid-device-vector-csv
vuule
added
4 - Needs cuIO Reviewer
and removed
0 - Waiting on Author
kaatish
reviewed
Apr 21, 2021
kaatish
approved these changes
Apr 21, 2021
vuule
added
5 - Ready to Merge
|
rerun tests |
|
@gpucibot merge |
harrism
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7287
Replaces
device_vectorwithdevice_uvectoranddevice_span. Removed thedevice_vectordata members.Performance impact:
up to 10% slower, will look into this.None