-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert cudf::rank to use device_uvector #8029
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8029 +/- ##
===============================================
- Coverage 82.88% 82.83% -0.06%
===============================================
Files 103 103
Lines 17668 17796 +128
===============================================
+ Hits 14645 14742 +97
- Misses 3023 3054 +31
Continue to review full report at Codecov.
|
karthikeyann
requested changes
Apr 22, 2021
nvdbaranec
requested changes
Apr 22, 2021
karthikeyann
approved these changes
Apr 23, 2021
nvdbaranec
approved these changes
Apr 23, 2021
kkraus14
approved these changes
Apr 26, 2021
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CMake
CMake build issue
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts
cudf::rank
to usedevice_uvector
instead ofdevice_vector
.Also adds a benchmark for
cudf::rank
.Contributes to #7287
Performance is at most 1.7% slower and up to 12% faster.