-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert cudf::merge to use device_uvector instead of device_vector #8043
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8043 +/- ##
===============================================
- Coverage 82.88% 82.84% -0.05%
===============================================
Files 103 103
Lines 17668 17804 +136
===============================================
+ Hits 14645 14750 +105
- Misses 3023 3054 +31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -14,6 +14,7 @@ | |||
* limitations under the License. | |||
*/ | |||
|
|||
#include "rmm/cuda_stream_view.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<>
preferred.
#include "rmm/cuda_stream_view.hpp" | |
#include <rmm/cuda_stream_view.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, have to update copyright
@karthikeyann @rgsl888prabhu please don't approve when changes are required, to prevent it getting merged before the fixes are made. |
Addressed and need to get debug build fixes in urgently.
@gpucibot merge |
Converts
cudf::merge
to usedevice_uvector
.Contributes to #7287
Performance is improved: