Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert benchmarks to use device_uvector #8208

Merged
merged 5 commits into from
May 13, 2021

Conversation

harrism
Copy link
Member

@harrism harrism commented May 11, 2021

Converts all remaining benchmark code to use device_uvector instead of device_vector.

Contributes to #7287

@harrism harrism requested a review from a team as a code owner May 11, 2021 05:47
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 11, 2021
@harrism harrism added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels May 11, 2021
@harrism harrism added this to PR-WIP in v21.06 Release via automation May 11, 2021
@harrism harrism self-assigned this May 11, 2021
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #8208 (b963929) into branch-0.20 (51336df) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b963929 differs from pull request most recent head 1c47010. Consider uploading reports for the commit 1c47010 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #8208      +/-   ##
===============================================
- Coverage        82.88%   82.88%   -0.01%     
===============================================
  Files              103      104       +1     
  Lines            17668    17904     +236     
===============================================
+ Hits             14645    14839     +194     
- Misses            3023     3065      +42     
Impacted Files Coverage Δ
python/cudf/cudf/core/tools/datetimes.py 80.42% <0.00%> (-4.11%) ⬇️
python/cudf/cudf/core/abc.py 87.50% <0.00%> (-3.99%) ⬇️
python/cudf/cudf/core/column/decimal.py 90.20% <0.00%> (-2.72%) ⬇️
python/cudf/cudf/core/column/datetime.py 88.03% <0.00%> (-1.88%) ⬇️
python/cudf/cudf/core/column/struct.py 94.73% <0.00%> (-1.56%) ⬇️
python/cudf/cudf/utils/dtypes.py 82.20% <0.00%> (-1.24%) ⬇️
python/dask_cudf/dask_cudf/groupby.py 91.28% <0.00%> (-0.88%) ⬇️
python/cudf/cudf/core/series.py 91.17% <0.00%> (-0.56%) ⬇️
python/cudf/cudf/core/index.py 92.52% <0.00%> (-0.55%) ⬇️
python/cudf/cudf/core/column/column.py 88.20% <0.00%> (-0.44%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c67de...1c47010. Read the comment docs.

Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Missing a couple of copyright updates.

cpp/benchmarks/iterator/iterator_benchmark.cu Show resolved Hide resolved
cpp/benchmarks/join/generate_input_tables.cuh Outdated Show resolved Hide resolved
v21.06 Release automation moved this from PR-WIP to PR-Needs review May 11, 2021
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 11, 2021
@harrism harrism requested a review from davidwendt May 11, 2021 22:38
v21.06 Release automation moved this from PR-Needs review to PR-Reviewer approved May 12, 2021
@harrism
Copy link
Member Author

harrism commented May 13, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 082596f into rapidsai:branch-0.20 May 13, 2021
v21.06 Release automation moved this from PR-Reviewer approved to Done May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants