Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeprecationWarning to ser.str.subword_tokenize #8603

Merged
merged 5 commits into from
Jul 8, 2021
Merged

Add DeprecationWarning to ser.str.subword_tokenize #8603

merged 5 commits into from
Jul 8, 2021

Conversation

VibhuJawa
Copy link
Member

@VibhuJawa VibhuJawa commented Jun 24, 2021 •
edited by galipremsagar
Loading

This PR adds deprecationWarning to ser.str.subword_tokenize .

Checkout related issue for details: #8604

@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 24, 2021
@VibhuJawa VibhuJawa added non-breaking Non-breaking change Python Affects Python cuDF API. and removed Python Affects Python cuDF API. labels Jun 24, 2021
@VibhuJawa VibhuJawa mentioned this pull request Jun 24, 2021
Closed
@VibhuJawa VibhuJawa marked this pull request as ready for review June 24, 2021 21:29
@VibhuJawa VibhuJawa requested a review from a team as a code owner June 24, 2021 21:29
@VibhuJawa VibhuJawa requested review from shwina and isVoid June 24, 2021 21:29
@codecov
Copy link

codecov bot commented Jun 24, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@f0f2170). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head eace4c0 differs from pull request most recent head 120c63e. Consider uploading reports for the commit 120c63e to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8603   +/-   ##
===============================================
  Coverage                ?   10.64%           
===============================================
  Files                   ?      109           
  Lines                   ?    18656           
  Branches                ?        0           
===============================================
  Hits                    ?     1985           
  Misses                  ?    16671           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f2170...120c63e. Read the comment docs.

@galipremsagar galipremsagar added the improvement Improvement / enhancement to an existing function label Jun 28, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jul 8, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a5427d2 into rapidsai:branch-21.08 Jul 8, 2021
@bdice bdice mentioned this pull request Sep 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr left review comments

@galipremsagar galipremsagar galipremsagar approved these changes

@shwina shwina Awaiting requested review from shwina

@isVoid isVoid Awaiting requested review from isVoid

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VibhuJawa @galipremsagar @vyasr