Refactor Python factories and remove usage of Table for libcudf output handling #8687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parse in Python.
…r the ColumnMethods).
…he ColumnMethods).
vyasr
added
3 - Ready for Review
vyasr
requested review from
shwina and
isVoid
and removed request for
marlenezw and
skirui-source
isVoid
reviewed
Jul 27, 2021
Co-authored-by: Michael Wang <isVoid@users.noreply.github.com>
isVoid
approved these changes
Jul 28, 2021
shwina
reviewed
Jul 28, 2021
shwina
approved these changes
Jul 29, 2021
|
Before merging, I'd check with cuML (cc: @dantegd) as well as cuGraph (cc: @BradReesWork) if/how this will break them. |
|
cc: @thomcom for cuSpatial as well |
|
I've already opened rapidsai/cuspatial#437 for when this PR gets merged, happy to help out if this affects cuML or cuGraph. |
rlratzel
approved these changes
Aug 3, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Aug 4, 2021
rapidsai/cudf#8687 changes the internals of cuDF and removes the means by which libcudf table objects are converted to cuDF Frames. This PR should be merged after that one to match those APIs. I have verified locally that this PR's Cython code compiles and runs against that branch of cuDF. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Paul Taylor (https://github.com/trxcllnt) URL: #437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves two purposes:
_from_datamethod) for constructing Frame-like objects from other Frame-like objects that uses the lowest common denominator (a dict of columns and an optional index) for all other current methods (e.g._from_tableand_copy_construct).