Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orc reader assert on create data_type in debug #8706

Merged

Conversation

davidwendt
Copy link
Contributor

The fix from #8174 got reverted in rework of orc/reader_impl.cu in #8599
This PR reinstates the original fix to prevent an assert in debug mode in gtests/ORC_TEST

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jul 9, 2021
@davidwendt davidwendt self-assigned this Jul 9, 2021
@davidwendt davidwendt requested a review from a team as a code owner July 9, 2021 15:14
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #8706 (0e5531c) into branch-21.08 (ecbec81) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 0e5531c differs from pull request most recent head ea5771d. Consider uploading reports for the commit ea5771d to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #8706      +/-   ##
================================================
- Coverage         10.62%   10.61%   -0.01%     
================================================
  Files               109      109              
  Lines             18291    18300       +9     
================================================
  Hits               1943     1943              
- Misses            16348    16357       +9     
Impacted Files Coverage Δ
python/cudf/cudf/core/scalar.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecbec81...ea5771d. Read the comment docs.

Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jul 12, 2021
@codereport
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0b9ea01 into rapidsai:branch-21.08 Jul 12, 2021
@davidwendt davidwendt deleted the bug-debug-orc-reader-again branch July 19, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants