Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix select_dtypes to work when non-class dtypes present in dataframe #8849

Merged
merged 5 commits into from
Jul 27, 2021
Merged

Fix select_dtypes to work when non-class dtypes present in dataframe #8849

merged 5 commits into from
Jul 27, 2021

Conversation

sarahyurick
Copy link
Contributor

Addresses bug #6919. issubclass expects a class, but a list is not a class, so we must add a check before calling issubclass on it.

@sarahyurick sarahyurick requested a review from a team as a code owner July 26, 2021 14:54
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 26, 2021
@beckernick
Copy link
Member

Since the PR title becomes the changelog entry, could you please update the title to reflect the nature of the bug fix? See here for an example of what happens.

@sarahyurick sarahyurick changed the title select_dtypes bug fix Fix select_dtypes to work when non-class dtypes present in dataframe Jul 26, 2021
@sarahyurick
Copy link
Contributor Author

this should have labels bug and non-breaking

@galipremsagar galipremsagar added 4 - Needs cuDF (Python) Reviewer bug Something isn't working non-breaking Non-breaking change labels Jul 26, 2021
@codecov
Copy link

codecov bot commented Jul 26, 2021 •
edited
Loading

Codecov Report

Merging #8849 (96d4977) into branch-21.10 (18f7c01) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 96d4977 differs from pull request most recent head 3ad6f78. Consider uploading reports for the commit 3ad6f78 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8849      +/-   ##
================================================
- Coverage         10.67%   10.58%   -0.10%     
================================================
  Files               110      116       +6     
  Lines             18271    18652     +381     
================================================
+ Hits               1951     1974      +23     
- Misses            16320    16678     +358
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <ø> (ø)
python/cudf/cudf/core/frame.py 0.00% <ø> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d942100...3ad6f78. Read the comment docs.

@galipremsagar galipremsagar changed the title Fix select_dtypes to work when non-class dtypes present in dataframe Fix select_dtypes to work when non-class dtypes present in dataframe Jul 27, 2021
galipremsagar
galipremsagar reviewed Jul 27, 2021
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comment..

python/cudf/cudf/tests/test_dataframe.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuDF (Python) Reviewer labels Jul 27, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5d5bb2c into rapidsai:branch-21.10 Jul 27, 2021
@galipremsagar galipremsagar linked an issue Jul 27, 2021 that may be closed by this pull request
[BUG]Select dtypes fails if list dtypes present in dataframe #6919
Closed
@galipremsagar galipremsagar mentioned this pull request Jul 27, 2021
Closed
@sarahyurick sarahyurick deleted the select_dtypes_list branch September 21, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

Assignees

@sarahyurick sarahyurick

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]Select dtypes fails if list dtypes present in dataframe
4 participants
@sarahyurick @beckernick @galipremsagar @shwina