Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix branch_stack calculation in row_bit_count() #9076

Merged
merged 2 commits into from Aug 23, 2021
Merged

Fix branch_stack calculation in row_bit_count() #9076

merged 2 commits into from Aug 23, 2021

Commits on Aug 19, 2021

  1. Fix branch_stack calculation in row_bit_count(): 

    For input with a number of rows exceeding  `max_block_size`, `row_bit_count()` currently
reaches past the bounds of its shared-memory allocation, causing illegal memory access
errors like in (cudf/issues/8938)[rapidsai#8938].

This commit corrects the calculation of the branch stack's base address, and adds a
test for this case.
    @mythrocks
    mythrocks committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    5330c3d View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Increase number of input rows for test.

    @mythrocks
    mythrocks committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    eeca5b7 View commit details
    Browse the repository at this point in the history