Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing %f in format to return nanoseconds #9081

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

marlenezw
Copy link
Contributor

This is a quick fix to close PR #7945
This PR checks to see if %f is passed as part of format into cudf.to_datetime. Previously, cudf would not return nanoseconds, while pandas does.

@marlenezw marlenezw requested a review from a team as a code owner August 20, 2021 09:19
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 20, 2021
@marlenezw marlenezw self-assigned this Aug 20, 2021
@marlenezw marlenezw added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 20, 2021
@marlenezw marlenezw added this to the Time Series Analysis milestone Aug 20, 2021
@marlenezw
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@eb85d77). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 127017b differs from pull request most recent head 1657b11. Consider uploading reports for the commit 1657b11 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9081   +/-   ##
===============================================
  Coverage                ?   10.73%           
===============================================
  Files                   ?      114           
  Lines                   ?    19057           
  Branches                ?        0           
===============================================
  Hits                    ?     2046           
  Misses                  ?    17011           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb85d77...1657b11. Read the comment docs.

@cwharris
Copy link
Contributor

rerun tests

@shwina
Copy link
Contributor

shwina commented Aug 23, 2021

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants