Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor C++17 cleanup of groupby.cu: structured bindings, more concise lambda, etc #9193

Merged
merged 8 commits into from Sep 9, 2021
Merged

Minor C++17 cleanup of groupby.cu: structured bindings, more concise lambda, etc #9193

merged 8 commits into from Sep 9, 2021

Conversation

codereport
Copy link
Contributor

Due to the fact that my soul is slowly melting away due to my current internal PR I am working on, I set up this small cleanup in hopes of getting a dopamine or endorphin hit.

@codereport codereport added 3 - Ready for Review Ready for review by team code quality libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 8, 2021
@codereport codereport self-assigned this Sep 8, 2021
@codereport codereport requested a review from a team as a code owner September 8, 2021 05:39
@codereport codereport added this to PR-WIP in v21.10 Release via automation Sep 8, 2021
rgsl888prabhu
rgsl888prabhu reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, apart from thing failing with rmm.

davidwendt
davidwendt approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR description somehow ends up in the changelog so you may want to consider replacing it with something more descriptive.

v21.10 Release automation moved this from PR-WIP to PR-Reviewer approved Sep 8, 2021
ttnghia
ttnghia approved these changes Sep 8, 2021
View reviewed changes
cpp/src/groupby/hash/groupby.cu Outdated Show resolved Hide resolved
cpp/src/groupby/hash/groupby.cu Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 8, 2021 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@9b532ab). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c3484e8 differs from pull request most recent head a87aed9. Consider uploading reports for the commit a87aed9 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9193   +/-   ##
===============================================
  Coverage                ?   10.77%           
===============================================
  Files                   ?      115           
  Lines                   ?    19138           
  Branches                ?        0           
===============================================
  Hits                    ?     2062           
  Misses                  ?    17076           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b532ab...a87aed9. Read the comment docs.

@codereport codereport changed the title Minor C++17 cleanup of groupby.cu: CTAD, structured bindings, more concise lambda Minor C++17 cleanup of groupby.cu: structured bindings, more concise lambda, etc Sep 9, 2021
@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Sep 9, 2021
@codereport
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f223901 into rapidsai:branch-21.10 Sep 9, 2021
v21.10 Release automation moved this from PR-Reviewer approved to Done Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu left review comments

@mythrocks mythrocks mythrocks approved these changes

@ttnghia ttnghia ttnghia approved these changes

@jrhemstad jrhemstad jrhemstad approved these changes

@davidwendt davidwendt davidwendt approved these changes

Assignees

@codereport codereport

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
No open projects
v21.10 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@codereport @mythrocks @ttnghia @jrhemstad @rgsl888prabhu @davidwendt