Consolidate binary ops into Frame
#9357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9357 +/- ##
================================================
- Coverage 10.79% 10.77% -0.02%
================================================
Files 116 116
Lines 18869 19444 +575
================================================
+ Hits 2036 2096 +60
- Misses 16833 17348 +515
Continue to review full report at Codecov.
|
vyasr
reviewed
Oct 4, 2021
|
@isVoid The description probably needs an update, after we made those changes Friday night we're no longer making use of |
isVoid
added
non-breaking
shwina
reviewed
Oct 4, 2021
vyasr
approved these changes
Oct 6, 2021
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
galipremsagar
requested changes
Oct 8, 2021
Co-authored-by: GALI PREM SAGAR <sagarprem75@gmail.com>
|
rerun tests |
shwina
reviewed
Oct 12, 2021
python/cudf/cudf/core/series.py
Outdated
|
|
||
| # The above has wrapped binary op function from `Frame` with `wrapper`, | ||
| # copied module level attributes to wrapper (`__docs__` etc.) and set | ||
| # `__wrapped__` attribute of `wrapper` to `Frame` binop. Since this wrapper |
There was a problem hiding this comment.
This comment is out of date, now that we set __signature__ instead.
There was a problem hiding this comment.
Well actually it's not out of date. @functools.wraps still sets the __wrapped__ attribute of wrapper to wrapped_func, and this makes the signature mismatches with the actual parameter list of wrapper, which is why we need to set the __signature__ attr below. I updated the docs with some explanation of cpython behavior here to hopefully make it a bit clearer to understand.
galipremsagar
approved these changes
Oct 13, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 2, 2021
This PR is a follow-up to #9357 that consolidates the comparison binops (eq, ne, lt, le, gt, ge) into Frame, enabling their use on DataFrame objects as well as Series. Note that pandas DataFrames do not support the fill_value parameter for these operations (unlike other binop functions), so we could choose to disable it for ours as well but I have not done so at present (I don't see a particularly strong reason to lean either way). Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - https://github.com/brandon-b-miller URL: #9542
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
…string (#10576) This PR moves all the binary operation methods such as `Frame.add` into `IndexedFrame`. This removes these methods from `Index` objects to match pandas, where Index objects do not have these methods. I have also consolidated the docstrings for these methods using a single template and our `docutils`. Note that this is technically a breaking change that I am implementing without a deprecation cycle; however, I feel comfortable doing so because these methods were introduced incidentally in #9357 and #9542 into 21.12, so just a couple of releases ago, and since they are not pandas APIs I doubt that they have made significant penetration into user workflows. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #10576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves #9038
This PR moves binary ops from
SeriesandDataFrameintoFrameto reduce duplications. Because the arguments takes a different order inseries.pyanddataframe.pyresort tofunctools.wrapsto reorder the arguments while keeping the docstrings the same.