Correct _LIBCUDACXX_CUDACC_VER value computation #9579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
github-actions
bot
added
CMake
codereport
approved these changes
Nov 2, 2021
|
Confirmed that this fixes my build for #9483 |
robertmaynard
added
5 - DO NOT MERGE
|
We should hold off on merging this while upstream decides what approach they want. That way we only have to update the patch file once. |
|
Happy to review this once libcudacxx decides what the supported way forward will be to check versions. |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9579 +/- ##
================================================
- Coverage 10.79% 10.65% -0.14%
================================================
Files 116 117 +1
Lines 18869 19746 +877
================================================
+ Hits 2036 2104 +68
- Misses 16833 17642 +809
Continue to review full report at Codecov.
|
harrism
approved these changes
Nov 3, 2021
robertmaynard
added
3 - Ready for Review
|
@vyasr @codereport This is ready for review as these changes have been accepted as is upstream ( NVIDIA/libcudacxx#225 ) |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the libcudacxx patch inline with the proposed upstream changes ( NVIDIA/libcudacxx#225 ).
This is needed so that CUDA versions are correctly computed and decimal-128 support is enabled when using CUDA 11.5+