Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stop instead of stop_. #9735

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 19, 2021

Small fix to inconsistent variable names in tests, following up from #9571.

Previous conversation: #9571 (comment)

@bdice bdice added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. tech debt non-breaking Non-breaking change labels Nov 19, 2021
@bdice bdice self-assigned this Nov 19, 2021
@bdice bdice requested a review from a team as a code owner November 19, 2021 16:34
@bdice bdice requested review from cwharris and vuule November 19, 2021 16:34
@bdice bdice added improvement Improvement / enhancement to an existing function code quality and removed tech debt labels Nov 19, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@55c9701). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 686fac7 differs from pull request most recent head 640c70f. Consider uploading reports for the commit 640c70f to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #9735   +/-   ##
===============================================
  Coverage                ?   10.49%           
===============================================
  Files                   ?      119           
  Lines                   ?    20305           
  Branches                ?        0           
===============================================
  Hits                    ?     2130           
  Misses                  ?    18175           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c9701...640c70f. Read the comment docs.

@bdice
Copy link
Contributor Author

bdice commented Nov 19, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 09a8a47 into rapidsai:branch-22.02 Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants