Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load libcufile.so with RTLD_NODELETE flag #9872

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Dec 8, 2021

Workaround for a known cuFile issue that can lead to segfault if cuFile library is dynamically unloaded.
Using RTLD_NODELETE when calling dlopen so that the library is not unloaded in dlclose.

Also adds a check for the result of dlopen, to help triage cuFile use issues.

@vuule vuule added bug Something isn't working cuIO cuIO issue non-breaking Non-breaking change labels Dec 8, 2021
@vuule vuule self-assigned this Dec 8, 2021
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #9872 (7551cf5) into branch-22.02 (967a333) will decrease coverage by 0.06%.
The diff coverage is 5.48%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9872      +/-   ##
================================================
- Coverage         10.49%   10.42%   -0.07%     
================================================
  Files               119      119              
  Lines             20305    20469     +164     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18335     +160     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a72f19e...7551cf5. Read the comment docs.

@vuule vuule marked this pull request as ready for review December 8, 2021 22:53
@vuule vuule requested a review from a team as a code owner December 8, 2021 22:53
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor question.

@vuule
Copy link
Contributor Author

vuule commented Dec 9, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8e5b23c into rapidsai:branch-22.02 Dec 9, 2021
@vuule vuule deleted the bug-cufile-dlopen branch December 9, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants