Fix null check when comparing structs in min and max reduction/groupby operations
#9994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
bug
|
Reference: NVIDIA/spark-rapids#4434 (that work is on spark-rapids plugin implementing |
This comment has been minimized.
This comment has been minimized.
hyperbolic2346
approved these changes
Jan 11, 2022
bdice
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
LGTM - @ttnghia can you please update the PR description to cross-reference the issues, PRs, and/or comments that led to discovering this bug and its fix? You referenced NVIDIA/spark-rapids#4434 but I don't immediately see the relationship to this PR.
edit: I think this comment is the one that explains it. This PR fixes the difference in CPU/GPU behavior from this thread: #8974 (comment)
|
@gpucibot merge |
ttnghia
changed the title
min and max reduction/groupby operationsmin and max reduction/groupby operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing structs, we need to flatten its view into a
table_viewand compare the table's rows. Nulls check for the comparison needs to be done by checking nulls in the input structs column at all levels.This PR fixes a bug that checks for nulls only at the top level. Unit tests designed specifically to detect this bug have also been added.