Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph primitives memory scaling improvements for low average vertex degree graphs and many GPUs (Part 1) #1801

Merged
merged 38 commits into from
Sep 9, 2021

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Sep 1, 2021

This PR updates graph primitives to take wrappers for row/column properties. This will enable us to pick either contiguous array or (key, value) pairs inside the wrapper based on the number of GPUs and the average vertex degree (compare V/sqrt(P) & E/P).

@seunghwak seunghwak requested a review from a team as a code owner September 1, 2021 14:22
@seunghwak seunghwak added 3 - Ready for Review DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #1801 (b34ef29) into branch-21.10 (bf64c2c) will increase coverage by 9.17%.
The diff coverage is n/a.

❗ Current head b34ef29 differs from pull request most recent head 8e9f472. Consider uploading reports for the commit 8e9f472 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #1801      +/-   ##
================================================
+ Coverage         59.85%   69.03%   +9.17%     
================================================
  Files                77      139      +62     
  Lines              3547     8425    +4878     
================================================
+ Hits               2123     5816    +3693     
- Misses             1424     2609    +1185     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/_version.py 44.40% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 90.00% <ø> (ø)
python/cugraph/link_prediction/jaccard.py
python/cugraph/traversal/ms_bfs.py
python/cugraph/community/triangle_count.py
python/cugraph/dask/traversal/sssp.py
python/cugraph/layout/force_atlas2.py
python/cugraph/link_prediction/overlap.py
... and 202 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d798f...8e9f472. Read the comment docs.

@seunghwak seunghwak removed the DO NOT MERGE Hold off on merging; see PR for details label Sep 4, 2021
@kaatish kaatish mentioned this pull request Sep 7, 2021
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the dummy_properties_t change. Definitely makes that easier to understand.

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5df5965 into rapidsai:branch-21.10 Sep 9, 2021
@seunghwak seunghwak deleted the fea_kv_pair_part1 branch October 19, 2021 21:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants