initial creation of libcugraph_etl.so #1885
Conversation
rlratzel
added
improvement
| * and/or dst_table that correspond to the vertex id | ||
| * | ||
| */ | ||
| std::tuple<cudf::column, cudf::column, cudf::table> renumber_cudf_tables( |
There was a problem hiding this comment.
I think this function should return unique_ptrs of each of the cudf::column and tables. Caller can take ownership of the pointers and release when done.
cpp/CMakeLists.txt
Outdated
| CUDA::curand | ||
| CUDA::cusolver | ||
| CUDA::cusparse | ||
| cugraph::cugraph |
There was a problem hiding this comment.
Does cugraph:cugraph adds libcudf as well? May want to ensure libcudf is linked as well.
There was a problem hiding this comment.
Seems likely. Until we have code in there I'm inclined not to worry too much about what we need. We also might be able to drop some of these entirely since they might not be used.
|
rerun tests |
|
rerun tests |
|
I think I have addressed the suggestions. I'd like to merge this soon if there are no other concerns. |
|
rerun tests |
3 similar comments
|
rerun tests |
|
rerun tests |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #1885 +/- ##
===============================================
Coverage ? 70.28%
===============================================
Files ? 143
Lines ? 8922
Branches ? 0
===============================================
Hits ? 6271
Misses ? 2651
Partials ? 0 Continue to review full report at Codecov.
|
…fter the pattern used by cudf and libkafka_cudf), in order for libcugraph to not have a new dependency on libcudf. The new etl library/package will be used only by users needing ETL functions, and the added dependency will only be required by them.
|
rerun tests |
|
rerun tests Want to make sure the latest cupy is being used. |
…ames paths differently now that multiple packages are built (eg. libcugraph and libcugraph_etl).
|
Hey, I think you also need to update the upload script to upload the new package |
|
@gpucibot merge |
The new renumbering implementation will require C++ integration directly with cudf. In order to facilitate that, but also support our customers that won't need cudf, this PR will create a separate library (
libcugraph_etl.so) which will ultimately link withlibcudf.soand contain the ETL portions of cugraph that require cudf features.This way our other libcugraph customers that don't need to reference the new library will not need to install all of the cudf dependencies.
To seed this, the PR also includes a proposed API for the new renumbering capability.