Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update probability params for RMAT call to match Graph500 #1952

Merged

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Nov 17, 2021

Update probability params for RMAT call to match Graph500.

This PR also contains a necessary change to the libcugraph_etl CMakeLists.txt file that fixes a problem with the GPU arch detection and filtering that was causing the build to fail.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 17, 2021
@rlratzel rlratzel self-assigned this Nov 17, 2021
@rlratzel rlratzel requested a review from a team as a code owner November 17, 2021 23:17
@rlratzel
Copy link
Contributor Author

rerun tests

Forward merge from 21.12 now in place, build should pass.

@rlratzel
Copy link
Contributor Author

rerun tests

@seunghwak
Copy link
Contributor

@rlratzel Better fix comments in https://github.com/rapidsai/cugraph/blob/branch-21.12/python/cugraph/cugraph/generators/rmat.py#L299 as well.

…remove build warnings about it being missing, updated supported_archs in libcugraph_etl CMakeLists.txt to match libcugraph.
@rlratzel rlratzel requested review from a team as code owners November 18, 2021 15:56
@BradReesWork BradReesWork added this to the 22.02 milestone Nov 18, 2021
@rlratzel
Copy link
Contributor Author

rerun tests

Re-running now that style checker has been updated for latest clang-tools.

…ists.txt file, since it is not needed for the etl library (and causes problems).
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@ee2d9b5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #1952   +/-   ##
===============================================
  Coverage                ?   70.28%           
===============================================
  Files                   ?      143           
  Lines                   ?     8922           
  Branches                ?        0           
===============================================
  Hits                    ?     6271           
  Misses                  ?     2651           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2d9b5...a9496cb. Read the comment docs.

@rlratzel
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 62615dc into rapidsai:branch-22.02 Nov 19, 2021
@rlratzel rlratzel deleted the branch-22.02-rmatoptionsupdate branch June 17, 2022 00:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants