Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial automated doctest, all current examples now pass, other documentation edits #2014

Merged
merged 22 commits into from Jan 27, 2022
Merged

Initial automated doctest, all current examples now pass, other documentation edits #2014

merged 22 commits into from Jan 27, 2022

Conversation

betochimas
Copy link
Contributor

@betochimas betochimas commented Jan 14, 2022 •
edited

Closes #2012 and #2022

@betochimas betochimas added 2 - In Progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@12b53c8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #2014   +/-   ##
===============================================
  Coverage                ?   72.90%           
===============================================
  Files                   ?      147           
  Lines                   ?     9537           
  Branches                ?        0           
===============================================
  Hits                    ?     6953           
  Misses                  ?     2584           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b53c8...2f829b8. Read the comment docs.

@caryr35 caryr35 added this to PRs in 22.02 Release Jan 19, 2022
@BradReesWork BradReesWork added this to the 22.02 milestone Jan 21, 2022
@betochimas betochimas mentioned this pull request Jan 26, 2022
Open
24 tasks
@BradReesWork BradReesWork modified the milestones: 22.02, 22.04 Jan 26, 2022
@BradReesWork BradReesWork removed this from PRs in 22.02 Release Jan 26, 2022
@BradReesWork BradReesWork added this to PRs in 22.04 Release Jan 26, 2022
@rlratzel rlratzel changed the title [WIP] Initial automated doctest, all current examples now pass, other documentation edits Initial automated doctest, all current examples now pass, other documentation edits Jan 26, 2022
@rlratzel rlratzel marked this pull request as ready for review January 26, 2022 18:44
@rlratzel rlratzel requested review from a team as code owners January 26, 2022 18:44
@rlratzel rlratzel added doc Documentation and removed DRAFT improvement Improvement / enhancement to an existing function labels Jan 26, 2022
rlratzel
rlratzel requested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks for all the hard work of going through everything.
I found a few issues, which shouldn't be too hard to address.

python/cugraph/cugraph/link_analysis/pagerank.py Outdated Show resolved Hide resolved
docs/cugraph/source/api_docs/traversal.rst Outdated Show resolved Hide resolved
python/cugraph/cugraph/dask/centrality/katz_centrality.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/dask/centrality/katz_centrality.py Show resolved Hide resolved
python/cugraph/cugraph/link_analysis/hits.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/linear_assignment/lap.py Show resolved Hide resolved
python/cugraph/cugraph/proto/components/scc.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/structure/convert_matrix.py Show resolved Hide resolved
python/cugraph/cugraph/structure/symmetrize.py Show resolved Hide resolved
python/cugraph/cugraph/tree/minimum_spanning_tree.py Show resolved Hide resolved
@BradReesWork BradReesWork removed this from PRs in 22.04 Release Jan 26, 2022
@BradReesWork BradReesWork added this to PRs in 22.02 Release Jan 26, 2022
@BradReesWork BradReesWork modified the milestones: 22.04, 22.02 Jan 26, 2022
acostadon
acostadon approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found a few defaults missing. Hopefully my comments got recorded.
So many files...things look great now.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2e781c1 into rapidsai:branch-22.02 Jan 27, 2022
22.02 Release automation moved this from PRs to Done Jan 27, 2022
@betochimas betochimas mentioned this pull request Mar 8, 2022
Closed
@rlratzel rlratzel mentioned this pull request Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@acostadon acostadon acostadon approved these changes

Assignees
No one assigned
Labels
doc Documentation non-breaking Non-breaking change
Projects
No open projects
22.02 Release
  
Done
Milestone
22.02
Development

Successfully merging this pull request may close these issues.

[DOC] The html help for multi_source_bfs is not present in the online docs
5 participants
@betochimas @codecov-commenter @BradReesWork @rlratzel @acostadon