Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and testing improvements #2037

Open
6 of 24 tasks
Tracked by #3296
betochimas opened this issue Jan 26, 2022 · 3 comments
Open
6 of 24 tasks
Tracked by #3296

Documentation and testing improvements #2037

betochimas opened this issue Jan 26, 2022 · 3 comments
Assignees
Labels
Epic Tracker for a relatively large body of work that is broken down into stories and issues

Comments

@betochimas
Copy link
Contributor

betochimas commented Jan 26, 2022

In 22.02, this began as a list of documentation/example/testing-related issues, and in 22.06, was updated to include issues found in releases 22.02 and 22.04.

It's now an epic, and previous issues listed will have been moved to more digestable issues.

Examples

Broken examples / Examples to revisit

  • cugraph.structure.symmetrize.symmetrize_ddf
  • cugraph.tree.minimum_spanning.tree.minimum_spanning_tree (PR 2256 will resolve this)
  • cugraph.tree.minimum_spanning.tree.maximum_spanning_tree (PR 2256 will resolve this)

Documentation

MNMG Client Helper

  • Multiple helper callables are used for MNMG algorithms, including rmat, bfs, sssp, wcc, katz_centrality, nbr_sampling. They are all labeled as 'call_xxx', where xxx could be rmat, hits, etc. All except rmat, hits, nbr_sampling are on the html docs, so would they rather be on there, or removed and hidden like it is for rmat?
  • Include remaining MNMG 'call' helpers, akak rmat, hits, nbr_sampling, pagerank to docs
    OR
  • Remove existing MNMG 'call' helpers, aka bfs, sssp, wcc, katz_centrality from docs (PR 2194)

Methods missing from html docs

  • Methods from cugraph.structure.number_map.NumberMap (to_internal_vertex_id, add_internal_vertex_id, from_internal_vertex_id, renumber_and_segment, renumber) (PR 2194)
  • Methods from cugraph.structure.property_graph.PropertyGraph (can be put in experimental section when ready)
  • Methods from cugraph.structure.graph_implementation.simpleGraph.simpleGraphImpl (to_pandas_edgelist, to_pandas_adjacency, to_numpy_array, to_numpy_matrix, view_edge_list, delete_edge_list, view_adj_list, view_transposed_adj_list, get_two_hop_neighbors, number_of_vertices, number_of_nodes, number_of_edges, in_degree, out_degree, degree, degrees, has_node, has_edge, has_self_loop, edges, nodes, neighbors, vertex_column_size) (PR 2086)

Not implemented/supported

Arguments currented not supported

  • centrality/betweenness_centrality.py
    • weight from betweenness_centrality
    • endpoint from betweenness_centrality
    • weight from edge_betweenness_centrality
  • centrality/katz_centrality.py
    • beta from katz_centrality
  • community/egonet.py
    • center=False (True is supported) from batched_ego_graphs
    • undirected=True (False is supported) from batched_ego_graphs
    • distance from batched_ego_graphs
  • dask/centrality/katz_centrality.py
    • beta from katz_centrality
  • link_analysis/hits.py
    • nstart from hits
    • normalized from hits
  • traversal/bfs.py
    • reverse from bfs_edges
    • sort_neighbors from bfs_edges

Methods currently not supported

  • concurrent_bfs from traversal/ms_bfs.py
  • multi_source_bfs from traversal/ms_bfs.py

FIXMEs

Design/implementation orientated FIXMEs

  • cugraph.comms.comms.get_n_workers ln:212
  • cugraph.community.ktruss_subgraph.k_truss ln:80
  • Multiple from cugraph.structure.graph_implementation.simpleGraph.simpleGraphImpl
@betochimas betochimas added ? - Needs Triage Need team to review and classify doc Documentation labels Jan 26, 2022
@github-actions github-actions bot added this to Needs prioritizing in Other Issues Jan 26, 2022
@BradReesWork BradReesWork added this to the 22.04 milestone Feb 15, 2022
@BradReesWork BradReesWork added this to Infrastructure and other in 22.04 Release Feb 15, 2022
@BradReesWork BradReesWork removed the ? - Needs Triage Need team to review and classify label Feb 15, 2022
@BradReesWork BradReesWork removed this from Infrastructure and other in 22.04 Release Mar 31, 2022
@BradReesWork BradReesWork removed this from Needs prioritizing in Other Issues Mar 31, 2022
@BradReesWork BradReesWork modified the milestones: 22.04, 22.06 Mar 31, 2022
@BradReesWork BradReesWork added this to Infrastructure and other in 22.06 Release Mar 31, 2022
@rapidsai rapidsai deleted a comment from github-actions bot Mar 31, 2022
@betochimas
Copy link
Contributor Author

This issue will shift into an epic-style issue for 22.06 release, starting back from the 22.02 cycle. Resolved bullets will have a PR issue attached to it, and if continued into 22.08, then unresolved bullets could be moved into next cycle's issue

@rlratzel rlratzel added the python label Apr 7, 2022
@betochimas betochimas changed the title [DOC] Suggested changes in documentation [WIP] [EPIC] Documentation and testing improvements Apr 14, 2022
@betochimas betochimas added the Epic Tracker for a relatively large body of work that is broken down into stories and issues label Apr 14, 2022
rapids-bot bot pushed a commit that referenced this issue Apr 30, 2022
This PR incorporates suggested changes from issue #2037, opened back in 22.02, as well as cleaning up documentation and testing code from 22.04 work.

Specifically, this PR does the following:
- Removes worker helpers from MNMG algos in the online documentation (e.g. `call_katz_centrality`, `call_louvain`, `call_wcc`)
- Adds helpers from comms such as `get_comms`, `get_session_id`, `get_2D_partition`, is_initialized that were previously missing
- Adds helpers from NumberMap such as `from_internal_vertex_id`, `to_internal_vertex_id`, `renumber`, `set_renumbered_col_names`
- Add MNMG Hits and Node2vec to docs
- Added docstring descriptions and examples to methods that were missing them
- Fixed docstring examples in `egonet.py`, `node2vec.py`
- Adds `pylibcugraph` docstring examples to the list of examples tested in `cugraph/tests/test_doctests.py`
- Adds support for MG Dask docstring example testing, tested in newly created `cugraph/tests/dask/test_mg_doctests.py` 

This PR addresses the items from and closes #2227.
This PR also closes #2193.

Authors:
  - https://github.com/betochimas

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2194
@BradReesWork BradReesWork moved this from Infrastructure and other to Longterm & EPICs in 22.06 Release May 5, 2022
@BradReesWork BradReesWork removed this from Longterm & EPICs in 22.06 Release May 26, 2022
@BradReesWork BradReesWork added this to Longterm & EPICs in 22.08 Release May 26, 2022
@BradReesWork BradReesWork removed this from the 22.06 milestone May 26, 2022
@betochimas
Copy link
Contributor Author

This EPIC lists some algorithms are missing support for certain parameters/methods, as well as some design-oriented FIXMEs. Overall, this EPIC is quite disjoint, and could be better broken apart into a few issues. Some progress was made on this EPIC but still incomplete.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@caryr35 caryr35 added this to Longterm & EPICs in 22.10 Release Aug 22, 2022
@caryr35 caryr35 removed this from Longterm & EPICs in 22.08 Release Aug 22, 2022
@caryr35 caryr35 added this to Longterm & EPICs in 22.12 Release Oct 18, 2022
@caryr35 caryr35 removed this from Longterm & EPICs in 22.10 Release Oct 18, 2022
@BradReesWork BradReesWork removed this from Longterm & EPICs in 22.12 Release Jan 12, 2023
@BradReesWork BradReesWork added ? - Needs Triage Need team to review and classify and removed ? - Needs Triage Need team to review and classify labels Jul 6, 2023
@kingmesal kingmesal assigned rlratzel and unassigned betochimas Aug 1, 2023
@rlratzel rlratzel changed the title [EPIC] Documentation and testing improvements Documentation and testing improvements Aug 1, 2023
@kingmesal kingmesal removed the doc Documentation label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Tracker for a relatively large body of work that is broken down into stories and issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants