Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off cuco dependency in RAFT. Re-establish explicit cuco and libcuxx cmake dependencies #2132

Merged
merged 14 commits into from
Apr 19, 2022
Merged

Turn off cuco dependency in RAFT. Re-establish explicit cuco and libcuxx cmake dependencies #2132

merged 14 commits into from
Apr 19, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Mar 21, 2022 •
edited
Loading

Note: This PR depends on rapidsai/raft#540 and should work once it is merged.

@cjnolet cjnolet requested a review from a team as a code owner March 21, 2022 22:40
@cjnolet
Copy link
Member Author

cjnolet commented Mar 22, 2022

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022 •
edited
Loading

Codecov Report

Merging #2132 (b3ee70f) into branch-22.06 (38be932) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.06    #2132      +/-   ##
================================================
+ Coverage         70.82%   70.86%   +0.04%     
================================================
  Files               170      170              
  Lines             11036    11036              
================================================
+ Hits               7816     7821       +5     
+ Misses             3220     3215       -5
Impacted Files Coverage Δ
python/cugraph/cugraph/structure/hypergraph.py 90.00% <100.00%> (ø)
.../cugraph/tests/test_edge_betweenness_centrality.py 84.93% <0.00%> (+0.60%) ⬆️
...graph/cugraph/tests/test_betweenness_centrality.py 83.01% <0.00%> (+0.62%) ⬆️
python/cugraph/cugraph/tests/test_graph_store.py 100.00% <0.00%> (+1.56%) ⬆️
python/cugraph/cugraph/tests/test_utils.py 75.55% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f545fa5...b3ee70f. Read the comment docs.

@cjnolet
Copy link
Member Author

cjnolet commented Mar 22, 2022

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Mar 22, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Mar 22, 2022

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Mar 22, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Mar 22, 2022

rerun tests

@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 22, 2022
@ChuckHastings ChuckHastings added this to the 22.04 milestone Mar 22, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Mar 22, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Mar 22, 2022

@BradReesWork @rlratzel @ChuckHastings I'm providing an update here- I was attempting to enable cugraph to override thrust, rmm, and cuco so they weren't locked to whatever version RAFT defines. I've since found that this breaks when explicitly excluding items like cuco in the conda packaging because the dependency is still added to the exports but is no longer "installed". I've since backed out those changes on the RAFT side so the cugraph CI should work again.

In the meantime, this is not going to be a 22.04 option.

@cjnolet cjnolet changed the base branch from branch-22.04 to branch-22.06 March 22, 2022 20:47
@BradReesWork BradReesWork removed this from the 22.04 milestone Mar 23, 2022
@BradReesWork BradReesWork added this to the 22.06 milestone Mar 23, 2022
@BradReesWork BradReesWork changed the base branch from branch-22.06 to branch-22.04 March 23, 2022 18:25
@BradReesWork BradReesWork modified the milestones: 22.06, 22.04 Mar 23, 2022
@cjnolet cjnolet marked this pull request as draft March 23, 2022 18:26
@cjnolet
Copy link
Member Author

cjnolet commented Mar 24, 2022

rerun tests

3 similar comments
@cjnolet
Copy link
Member Author

cjnolet commented Mar 24, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Mar 25, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Mar 25, 2022

rerun tests

@BradReesWork BradReesWork changed the base branch from branch-22.04 to branch-22.06 March 28, 2022 17:51
@BradReesWork BradReesWork modified the milestones: 22.04, 22.06 Mar 28, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Mar 28, 2022

rerun tests

2 similar comments
@cjnolet
Copy link
Member Author

cjnolet commented Apr 2, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Apr 5, 2022

rerun tests

rlratzel
rlratzel approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question below, which need not hold up approval now.

cpp/cmake/thirdparty/get_raft.cmake Show resolved Hide resolved
@cjnolet cjnolet marked this pull request as ready for review April 19, 2022 16:52
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit eae7795 into rapidsai:branch-22.06 Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@cjnolet cjnolet

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.06
Development

Successfully merging this pull request may close these issues.
5 participants
@cjnolet @codecov-commenter @BradReesWork @rlratzel @ChuckHastings