updated MG Test code to not use DiGraph #2213
Conversation
BradReesWork
added
improvement
BradReesWork
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2213 +/- ##
================================================
+ Coverage 70.82% 71.00% +0.18%
================================================
Files 170 170
Lines 11036 11015 -21
================================================
+ Hits 7816 7821 +5
+ Misses 3220 3194 -26
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks good, just a couple of questions/suggestions below but I'll approve now since they're optional.
Also, if we want CI to run these MG tests using a single GPU, we'll also need to remove the --ignore=tests/dask option in this script here.
| @@ -13,17 +13,17 @@ | |||
|
|
|||
| import cugraph.dask as dcg | |||
| import gc | |||
| import pytest | |||
| # import pytest | |||
There was a problem hiding this comment.
Should this dead code be removed now?
There was a problem hiding this comment.
I left that in there in case we want to re-enable MG only testing. pytest is needed for the skip
| ) | ||
| # @pytest.mark.skipif( | ||
| # is_single_gpu(), reason="skipping MG testing on Single GPU system" | ||
| # ) | ||
| def test_dask_bfs(dask_client): | ||
| gc.collect() |
There was a problem hiding this comment.
optional: I've been using a single module-level setup function instead (like this) and removing all the individual gc.collect() calls.
|
@gpucibot merge |
replace all DiGraph with Graph(directed=True)
Set some test to run on single GPU