Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split update_v_frontier_from_outgoing_e to two simpler primitives #2290

Merged
merged 27 commits into from
May 25, 2022

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented May 19, 2022

Close #2003

  • Split update_v_frontier_from_outgoing_e to transform_reduce_v_frontier_outgoing_e_by_dst and update_v_frontier
  • Previously per_v was used to specify both vertex-centric primitives (e.g. for each vertex, iterate over all the incoming or outgoing edges) AND reduction granularity of edge operation outputs (e.g. reduce edge operation outputs by keys associated with destinations). Updated to use by_... to specify reduction granularity.
  • Bug fix in update_v_frontier_from_outgoing_e when key_t == vertex_t && payload_t = void.
  • Other code-style updates.

@seunghwak seunghwak added 2 - In Progress improvement Improvement / enhancement to an existing function breaking Breaking change labels May 19, 2022
@seunghwak seunghwak self-assigned this May 19, 2022
@seunghwak seunghwak added this to the 22.06 milestone May 19, 2022
@seunghwak seunghwak changed the title Split update_v_frontier_from_outgoing_e to two simpler primitives [skip-ci] Split update_v_frontier_from_outgoing_e to two simpler primitives May 19, 2022
@seunghwak seunghwak changed the title [skip-ci] Split update_v_frontier_from_outgoing_e to two simpler primitives Split update_v_frontier_from_outgoing_e to two simpler primitives May 20, 2022
@seunghwak seunghwak marked this pull request as ready for review May 20, 2022 22:59
@seunghwak seunghwak requested review from a team as code owners May 20, 2022 22:59
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2022

Codecov Report

Merging #2290 (a0122a2) into branch-22.06 (38be932) will decrease coverage by 7.03%.
The diff coverage is n/a.

❗ Current head a0122a2 differs from pull request most recent head 486ed62. Consider uploading reports for the commit 486ed62 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06    #2290      +/-   ##
================================================
- Coverage         70.82%   63.78%   -7.04%     
================================================
  Files               170      100      -70     
  Lines             11036     4498    -6538     
================================================
- Hits               7816     2869    -4947     
+ Misses             3220     1629    -1591     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 89.65% <ø> (ø)
...on/cugraph/cugraph/centrality/degree_centrality.py 81.81% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 88.23% <ø> (-1.24%) ⬇️
python/cugraph/cugraph/community/egonet.py 97.36% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 88.23% <ø> (+2.94%) ⬆️
python/cugraph/cugraph/community/leiden.py 100.00% <ø> (+7.69%) ⬆️
python/cugraph/cugraph/community/louvain.py 100.00% <ø> (+7.69%) ⬆️
python/cugraph/cugraph/community/triangle_count.py 100.00% <ø> (+11.11%) ⬆️
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0531d...486ed62. Read the comment docs.

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f55d2e5 into rapidsai:branch-22.06 May 25, 2022
@seunghwak seunghwak deleted the enh_update_frontier_split branch August 11, 2022 23:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Improve graph primitives API for better usability
4 participants