Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SG tested Leiden #2980

Merged
merged 101 commits into from
Apr 3, 2023
Merged

SG tested Leiden #2980

merged 101 commits into from
Apr 3, 2023

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Nov 25, 2022 •
edited
Loading

Leiden algorithm

This PR adds Leiden implementation using cugraph primitives. It also add an implementation of maximal independent set using cugraph primitives that is used by the Leiden implementation.

  • It reuses code from Louvain implementation to find locally optimal moves for vertices.
  • Locally optimal movement creates clusters of Louvain communities
  • In refinement phase, which is the main feature of Leiden algorithm, vertices are moved only within a Louvain community to subdivide a Louvain community in multiple sub communities or Leiden communities
  • In graph contraction phase, vertices belonging to a Leiden community are merged to become a node in aggregated graph.

This code has been tested to work on SG. We aim to test MG version in next release.
Future improvement:

  • Move vertices randomly instead of greedily refinement phase
  • Test for MNMG

Md Naim and others added 18 commits September 5, 2022 09:27
Renames variables
7903391
intermediate commit: Primitives call to compute some components of Le…
063821a 
…iden, need to add more to make it complete
Adds leiden to louvain mapping.
6791a65
Adds leiden to louvain mapping.
1a043be
Returns leiden to louvain mapping from refined partition
fa086ab
Return renumbering map from graph_contraction
b461d0b
Preserve original louvain partition of refined graph
4ac3f47
Merge branch 'branch-22.12' of github.com:rapidsai/cugraph into leide…
40a99f4 
…n-on-22-12
Fix errors that resulted in merging new changes from 22.12
2b4f37d
Add view_concat for edge_minor_property_view_t, change transform_redu…
46db0ca 
…ce_e_by_dst_key to support reduce op on tuple data types
Isolate refine_clustering in a separate file to make compilation fast…
8ef174b 
…er during development
Merge branch 'branch-22.12' of github.com:rapidsai/cugraph into leide…
43b6605 
…n-on-22-12
Use per_v_transform_reduce_dst_key_aggregated_outgoing_e with kv_stor…
4f5d3ea 
…e and construct decision graph
@naimnv
Merge branch 'rapidsai:branch-22.12' into leiden-on-22-12
5057a83
MIS to find a non-conflicting set of moves
ec765b8
Fix merge issues
90b8371
Fix merge issues
4c3875f
Merge branch 'leiden-on-22-12' of github.com:naimnv/cugraph-forked in…
ba9233e 
…to leiden-on-22-12
@naimnv naimnv changed the title Leiden on 22 12 [WIP] MG Leiden Nov 25, 2022
@BradReesWork BradReesWork added this to the 23.02 milestone Nov 28, 2022
Md Naim and others added 13 commits March 28, 2023 14:55
Merge branch 'branch-23.04' of github.com:rapidsai/cugraph into leide…
1b266c2 
…n-on-22-12
Merge branch 'leiden-on-22-12' of github.com:naimnv/cugraph-forked in…
3b6f81c 
…to leiden-on-22-12
Merge branch 'branch-23.04' of github.com:rapidsai/cugraph into leide…
35f3472 
…n-on-22-12
Add missing placeholer return value rapidsai#2980
ae455ab
Add missing template parameter to function call rapidsai#2980
52d15cb
Replace CUDA_TRY with RAFT_CUDA_TRY
e72bb15
Fix copyright rapidsai#3389
389a23d
@ChuckHastings
also update CHECK_CUDA to RAFT_CHECK_CUDA
a03108d
Fix PR issues rapidsai#2980
f4e3e1b
Merge commit 'refs/pull/3389/head' of github.com:rapidsai/cugraph int…
25879ff 
…o leiden-on-22-12
Update test to use files from only /datasets rapidsai#2980
48281ff
Replace reduce_op_t with reduce_op::maximum rapidsai#2980
5d0683c
Update and add missing documentation rapidsai#2980
d0b0d63
seunghwak
seunghwak reviewed Mar 29, 2023
View reviewed changes
cpp/include/cugraph/algorithms.hpp Outdated Show resolved Hide resolved
cpp/src/community/detail/common_methods.cuh Outdated Show resolved Hide resolved
cpp/src/community/detail/common_methods.cuh Outdated Show resolved Hide resolved
cpp/src/community/leiden_impl.cuh Outdated Show resolved Hide resolved
cpp/src/community/leiden_impl.cuh Outdated Show resolved Hide resolved
ChuckHastings
ChuckHastings reviewed Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of little cosmetic comments.

cpp/src/community/detail/common_methods.cuh Outdated Show resolved Hide resolved
cpp/src/community/detail/mis.hpp Outdated Show resolved Hide resolved
cpp/src/community/detail/mis_mg.cu Outdated Show resolved Hide resolved
cpp/src/community/detail/mis_sg.cu Outdated Show resolved Hide resolved
cpp/src/community/detail/refine.hpp Outdated Show resolved Hide resolved
cpp/src/community/detail/refine_mg.cu Outdated Show resolved Hide resolved
cpp/src/community/detail/refine_sg.cu Outdated Show resolved Hide resolved
cpp/src/community/leiden_impl.cuh Outdated Show resolved Hide resolved
cpp/src/community/leiden_mg.cu Outdated Show resolved Hide resolved
cpp/tests/community/new_leiden_test.cpp Outdated Show resolved Hide resolved
@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit d0cc407 into rapidsai:branch-23.04 Apr 3, 2023
@naimnv naimnv deleted the leiden-on-22-12 branch April 4, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@seunghwak seunghwak seunghwak approved these changes

Assignees

@naimnv naimnv

Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
23.04
Development

Successfully merging this pull request may close these issues.
6 participants
@naimnv @ChuckHastings @seunghwak @kingmesal @BradReesWork @jnke2016