Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Small fp precision failure in linear regression doctest test #4860

Closed
dantegd opened this issue Aug 8, 2022 · 1 comment · Fixed by #4884
Closed

[BUG] Small fp precision failure in linear regression doctest test #4860

dantegd opened this issue Aug 8, 2022 · 1 comment · Fixed by #4884
Labels
? - Needs Triage Need team to review and classify bug Something isn't working inactive-30d
Projects
Bug Squashing

Comments

@dantegd
Copy link
Member

dantegd commented Aug 8, 2022

Describe the bug
A couple of nightly runs, like https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/branches/job/cuml-gpu-arch-branch-22.08/CUDA=11.5,GPU_LABEL=gpu-t4/39/testReport/cuml.tests/test_doctest/test_docstring_LinearRegression_/, have shown the following pytest failure:

E         File "/opt/conda/envs/rapids/lib/python3.8/site-packages/cuml/linear_model/linear_regression.cpython-38-x86_64-linux-gnu.so", line ?, in LinearRegression
E         Failed example:
E             print(preds)
E         Expected:
E             0   15.999...
E             1   14.999...
E             dtype: float32
E         Got:
E             0    16.000000
E             1    14.999999
E             dtype: float32
@dantegd dantegd added bug Something isn't working ? - Needs Triage Need team to review and classify labels Aug 8, 2022
@github-actions github-actions bot added this to Needs prioritizing in Bug Squashing Aug 8, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@lowener lowener mentioned this issue Sep 8, 2022
Merged
@rapids-bot rapids-bot bot closed this as completed in #4884 Sep 8, 2022
Bug Squashing automation moved this from Needs prioritizing to Closed Sep 8, 2022
rapids-bot bot pushed a commit that referenced this issue Sep 8, 2022
@lowener
Fix small fp precision failure in linear regression doctest test (#4884)
6b67dd4 
Closes #4860.
Skipping this doctest. There are already pytests to check the correctness of the computation with precision tolerance.

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4884
jakirkham pushed a commit to jakirkham/cuml that referenced this issue Feb 27, 2023
@lowener
Fix small fp precision failure in linear regression doctest test (rap…
f906d93 
…idsai#4884)

Closes rapidsai#4860.
Skipping this doctest. There are already pytests to check the correctness of the computation with precision tolerance.

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify bug Something isn't working inactive-30d
Projects
Bug Squashing
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix small fp precision failure in linear regression doctest test lowener/cuml
1 participant
@dantegd