Fix small fp precision failure in linear regression doctest test #4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowener
added
bug
Codecov ReportBase: 78.02% // Head: 78.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #4884 +/- ##
================================================
+ Coverage 78.02% 78.07% +0.05%
================================================
Files 180 180
Lines 11385 11443 +58
================================================
+ Hits 8883 8934 +51
- Misses 2502 2509 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dantegd
approved these changes
Sep 8, 2022
|
@gpucibot merge |
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
…idsai#4884) Closes rapidsai#4860. Skipping this doctest. There are already pytests to check the correctness of the computation with precision tolerance. Authors: - Micka (https://github.com/lowener) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4860.
Skipping this doctest. There are already pytests to check the correctness of the computation with precision tolerance.