Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace device_memory_resource* with device_async_resource_ref #5839

Closed
Tracked by #16
, #1443
...
harrism opened this issue Apr 10, 2024 · 0 comments · Fixed by #5853
Closed
Tracked by #16
, #1443
...

Replace device_memory_resource* with device_async_resource_ref #5839

harrism opened this issue Apr 10, 2024 · 0 comments · Fixed by #5853
Labels
improvement Improvement / enhancement to an existing function

Comments

@harrism
Copy link
Member

harrism commented Apr 10, 2024

Update occurences of rmm::mr::device_memory_resource* to
rmm::device_async_resource_ref in this repo. The rationale is explained
in this document.
@harrism harrism added the improvement Improvement / enhancement to an existing function label Apr 10, 2024
@harrism harrism mentioned this issue Apr 18, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue Apr 22, 2024
@harrism
Replace rmm::mr::device_memory_resource* with rmm::device_async_resou…
b5309dc 
…rce_ref (#5853)

Closes #5839

Replaces all occurrences of rmm::mr::device_memory_resource* in parameters with rmm::device_async_resource_ref. Also updates calls to raw `resource->allocate()` to use `resource_ref.allocate_async()` with default alignment argument. Same for `deallocate()`.

Ideally would replace these with `device_uvector` / `device_buffer` but that is outside scope of this PR. See #5852

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Divye Gala (https://github.com/divyegala)

URL: #5853
This was referenced Apr 23, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace rmm::mr::device_memory_resource* with rmm::device_async_resource_ref harrism/cuml
1 participant
@harrism