Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove most warnings from pytest suite #4196

Merged
merged 19 commits into from
Nov 8, 2021
Merged

Remove most warnings from pytest suite #4196

merged 19 commits into from
Nov 8, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Sep 8, 2021 •
edited

Partially resolves #2843

Missing to deal with is warnings coming from cuML logger and other verbosity in the C++ layer

Note: Scikit-learn 0.24 removes many warnings as well, so once #4205 is merged and that is updated in CI the remaining warnings should be gone

@dantegd dantegd requested a review from a team as a code owner September 8, 2021 01:57
@github-actions github-actions bot added the gpuCI gpuCI issue label Sep 8, 2021
@dantegd dantegd requested a review from a team as a code owner September 8, 2021 14:19
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Sep 8, 2021
@dantegd dantegd added the bug Something isn't working label Sep 8, 2021
@dantegd dantegd changed the title DBG Test Scikit-learn 0.24 Update trustworthiness imports for Scikit-learn 0.24 in pytests Sep 8, 2021
@dantegd dantegd added 2 - In Progress Currenty a work in progress non-breaking Non-breaking change tests Unit testing for project labels Sep 8, 2021
@dantegd dantegd added this to PR-WIP in v21.10 Release via automation Sep 8, 2021
@dantegd dantegd changed the title Update trustworthiness imports for Scikit-learn 0.24 in pytests Update trustworthiness imports for Scikit-learn 0.24 in pytests [skip-ci] Sep 9, 2021
@dantegd dantegd changed the title Update trustworthiness imports for Scikit-learn 0.24 in pytests [skip-ci] Remove all warnings from pytest suite Sep 10, 2021
@github-actions github-actions bot removed the gpuCI gpuCI issue label Sep 10, 2021
@dantegd dantegd added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Sep 10, 2021
@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

cjnolet
cjnolet requested changes Sep 16, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one very minor thing. Otherwise, these changes are pretty straightforward.

python/cuml/manifold/t_sne.pyx Outdated
warnings.warn("Barnes Hut and FFT only work when "
"n_components == 2. Switching to exact.")
method = 'exact'
# Enable warning once n_components >= 2 is supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed altogether, else we should probably reference an issue here for tracking. I'm just not sure I see this feature being implemented anytime soon.

v21.10 Release automation moved this from PR-WIP to PR-Needs review Sep 16, 2021
@dantegd dantegd removed this from PR-Needs review in v21.10 Release Sep 29, 2021
@dantegd dantegd added this to PR-WIP in v21.12 Release via automation Sep 29, 2021
@dantegd dantegd changed the title Remove all warnings from pytest suite Remove all warnings from pytest suite [skip-ci] Oct 27, 2021
@dantegd dantegd requested review from a team as code owners October 27, 2021 16:48
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added CMake conda conda issue CUDA/C++ gpuCI gpuCI issue labels Oct 27, 2021
@dantegd dantegd changed the title Remove all warnings from pytest suite [skip-ci] Remove all warnings from pytest suite Nov 4, 2021
@dantegd dantegd changed the base branch from branch-21.10 to branch-21.12 November 4, 2021 20:27
@github-actions github-actions bot removed conda conda issue CMake CUDA/C++ gpuCI gpuCI issue labels Nov 4, 2021
cjnolet
cjnolet approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

v21.12 Release automation moved this from PR-WIP to PR-Reviewer approved Nov 4, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@ac33c34). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4196   +/-   ##
===============================================
  Coverage                ?   85.99%           
===============================================
  Files                   ?      231           
  Lines                   ?    18713           
  Branches                ?        0           
===============================================
  Hits                    ?    16093           
  Misses                  ?     2620           
  Partials                ?        0
Flag Coverage Δ
dask 46.97% <0.00%> (?)
non-dask 78.69% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac33c34...688b89e. Read the comment docs.

@dantegd dantegd changed the title Remove all warnings from pytest suite Remove most warnings from pytest suite Nov 5, 2021
@dantegd
Copy link
Member Author

dantegd commented Nov 8, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 287df1a into rapidsai:branch-21.12 Nov 8, 2021
v21.12 Release automation moved this from PR-Reviewer approved to Done Nov 8, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Remove most warnings from pytest suite (rapidsai#4196)
7ea3d71 
Partially resolves rapidsai#2843 

Missing to deal with is warnings coming from cuML logger and other verbosity in the C++ layer

Note: Scikit-learn 0.24 removes many warnings as well, so once rapidsai#4205 is merged and that is updated in CI the remaining warnings should be gone

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change tests Unit testing for project
Projects
No open projects
v21.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Ignore excessive warnings in pytests / CI logs
4 participants
@dantegd @ajschmidt8 @codecov-commenter @cjnolet