Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest updates for Scikit-learn 0.24 #4205

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Sep 13, 2021

No description provided.

@dantegd dantegd added 3 - Ready for Review Ready for review by team tests Unit testing for project improvement Improvement / enhancement to an existing function labels Sep 13, 2021
@dantegd dantegd requested a review from a team as a code owner September 13, 2021 13:46
@dantegd dantegd added this to PR-WIP in v21.10 Release via automation Sep 13, 2021
@dantegd dantegd added the non-breaking Non-breaking change label Sep 13, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Sep 13, 2021
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@36b3746). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #4205   +/-   ##
===============================================
  Coverage                ?   86.07%           
===============================================
  Files                   ?      231           
  Lines                   ?    18637           
  Branches                ?        0           
===============================================
  Hits                    ?    16042           
  Misses                  ?     2595           
  Partials                ?        0           
Flag Coverage Δ
dask 47.05% <0.00%> (?)
non-dask 78.73% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b3746...a3b8d6e. Read the comment docs.

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

v21.10 Release automation moved this from PR-WIP to PR-Reviewer approved Sep 13, 2021
@dantegd
Copy link
Member Author

dantegd commented Sep 13, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b459603 into rapidsai:branch-21.10 Sep 13, 2021
v21.10 Release automation moved this from PR-Reviewer approved to Done Sep 13, 2021
rapids-bot bot pushed a commit that referenced this pull request Nov 8, 2021
Partially resolves #2843 

Missing to deal with is warnings coming from cuML logger and other verbosity in the C++ layer

Note: Scikit-learn 0.24 removes many warnings as well, so once #4205 is merged and that is updated in CI the remaining warnings should be gone

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #4196
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Partially resolves rapidsai#2843 

Missing to deal with is warnings coming from cuML logger and other verbosity in the C++ layer

Note: Scikit-learn 0.24 removes many warnings as well, so once rapidsai#4205 is merged and that is updated in CI the remaining warnings should be gone

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tests Unit testing for project
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants