RF: python api behaviour refactor #4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkywonka
added
2 - In Progress
venkywonka
removed
doc
venkywonka
added
3 - Ready for Review
|
rerun tests |
|
@venkywonka I just reproduced the issue of CI in plain branch-21.10 locally, so on Monday we'll work on unblocking CI |
|
that's great @dantegd, thank you 🙏 |
|
rerun tests |
|
The latest |
dantegd
approved these changes
Sep 20, 2021
| "the number of samples used for training. " | ||
| "Changing `n_bins` to number of training samples." | ||
| in str(w[-1].message)) | ||
| print(str(w[-1].message)) |
There was a problem hiding this comment.
Suggested change
| print(str(w[-1].message)) |
I don't think it is necessary to print the message, maybe only if it is wrong?
There was a problem hiding this comment.
oh yea, that's on me will get rid of it, dante
|
@gpucibot merge |
RAMitchell
approved these changes
Sep 21, 2021
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #4207 +/- ##
===============================================
Coverage ? 86.07%
===============================================
Files ? 231
Lines ? 18633
Branches ? 0
===============================================
Hits ? 16039
Misses ? 2594
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This PR ⬇️ * fixes rapidsai#4193 and fixes rapidsai#4194 that relates to API incompatibility with dask-ml GridSearchCV * changes the behaviour of cuml RF in the following cases: * In the not-so-uncommon case when `n_bins` > number of rows in training sample, instead of throwing error and exiting, the estimator is made to print a warning and use the `n_bins` as the number of training samples. * When `.predict()` is called using `float64` data, instead of throwing an error asking user to explicitly specify `predict_model="CPU"` and rerun, a warning is displayed and implicity defaults to CPU-based prediction from the default GPU-based prediction. * Corresponding tests to capture the warnings from above added * the estimators now accept both numbers and strings as input for `split_criterion` parameter thus in parity with sklearn's API that takes in strings as criterion. * `split_algo` and `use_experimental_backend` parameters of the estimator class have now been completely removed from both documentation and warnings after deprecation in previous releases (from both single-gpu and dask RF). * `num_classes` parameter of predict and score methods have also been similarly removed Authors: - Venkat (https://github.com/venkywonka) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Rory Mitchell (https://github.com/RAMitchell) URL: rapidsai#4207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ⬇️
n_bins> number of rows in training sample, instead of throwing error and exiting, the estimator is made to print a warning and use then_binsas the number of training samples..predict()is called usingfloat64data, instead of throwing an error asking user to explicitly specifypredict_model="CPU"and rerun, a warning is displayed and implicity defaults to CPU-based prediction from the default GPU-based prediction.split_criterionparameter thus in parity with sklearn's API that takes in strings as criterion.split_algoanduse_experimental_backendparameters of the estimator class have now been completely removed from both documentation and warnings after deprecation in previous releases (from both single-gpu and dask RF).num_classesparameter of predict and score methods have also been similarly removed