Fix unnecessary f32/f64 conversions in t-SNE KL calc #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code compiles to cvt.f64.f32 %fd1, %f1; add.f64 %fd2, %fd1, 0d3FF0000000000000; mul.f64 %fd3, %fd2, 0d3FE0000000000000; cvt.rn.f32.f64 %f2, %fd3; instead of just add.f32 %f2, %f1, 0f3F800000; mul.f32 %f3, %f2, 0f3F000000;
|
Can one of the admins verify this patch? |
dantegd
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Thanks for the fix @zbjornson ! The CI issue will be solved in #4333 so will merge your PR just after that is in
|
ok to test |
|
rerun tests |
dantegd
added
improvement
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #4331 +/- ##
===============================================
Coverage ? 86.05%
===============================================
Files ? 231
Lines ? 18778
Branches ? 0
===============================================
Hits ? 16159
Misses ? 2619
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
The old code compiles to ```asm cvt.f64.f32 %fd1, %f1; add.f64 %fd2, %fd1, 0d3FF0000000000000; mul.f64 %fd3, %fd2, 0d3FE0000000000000; cvt.rn.f32.f64 %f2, %fd3; ``` instead of just ```asm add.f32 %f2, %f1, 0f3F800000; mul.f32 %f3, %f2, 0f3F000000; ``` Authors: - Zach Bjornson (https://github.com/zbjornson) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code compiles to
instead of just