float64 support in multi-sum and child_index() #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed default T=float from multi-sum - tests with float64 for multi-sum and child_index()
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #4648 +/- ##
===============================================
Coverage ? 83.86%
===============================================
Files ? 251
Lines ? 20293
Branches ? 0
===============================================
Hits ? 17018
Misses ? 3275
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
wphicks
reviewed
Mar 23, 2022
cpp/test/sg/fil_child_index_test.cu
Outdated
Comment on lines
55
to
62
| operator dense_node<float>() | ||
| { | ||
| return dense_node<float>({}, split<float>(), fid, def_left, false, is_categorical); | ||
| } | ||
| operator dense_node<double>() | ||
| { | ||
| return dense_node<double>({}, split<double>(), fid, def_left, false, is_categorical); | ||
| } |
There was a problem hiding this comment.
Any reason not to write this as a single template?
There was a problem hiding this comment.
Done. Thanks for the suggestion!
cpp/test/sg/fil_child_index_test.cu
Outdated
Comment on lines
65
to
70
| return sparse_node16<float>({}, split<float>(), fid, def_left, false, is_categorical, left); | ||
| } | ||
| operator sparse_node8() | ||
| operator sparse_node16<double>() | ||
| { | ||
| return sparse_node8({}, split(), fid, def_left, false, is_categorical, left); | ||
| return sparse_node16<double>({}, split<double>(), fid, def_left, false, is_categorical, left); | ||
| } |
There was a problem hiding this comment.
Same here: Any reason not to use a single template for this?
dantegd
added
improvement
divyegala
approved these changes
Mar 24, 2022
Co-authored-by: Divye Gala <divyegala@gmail.com>
|
@wphicks I've addressed all of your comments. Could you take another look? |
|
rerun tests |
|
rerun tests |
wphicks
approved these changes
Mar 28, 2022
|
@gpucibot merge |
|
rerun tests |
2 similar comments
|
rerun tests |
|
rerun tests |
venkywonka
pushed a commit
to venkywonka/cuml
that referenced
this pull request
Apr 26, 2022
- removed default `T = float` from multi-sum - tests with float64 for multi-sum and `child_index()` - refactored multi-sum tests to reduce shared memory usage - this is needed for the tests with float64 to compile This is pull request 1 of 3 to integrate rapidsai#4646. This pull request is partly based on the work by @levsnv. Authors: - Andy Adinets (https://github.com/canonizer) Approvers: - Divye Gala (https://github.com/divyegala) - William Hicks (https://github.com/wphicks) URL: rapidsai#4648
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
- removed default `T = float` from multi-sum - tests with float64 for multi-sum and `child_index()` - refactored multi-sum tests to reduce shared memory usage - this is needed for the tests with float64 to compile This is pull request 1 of 3 to integrate rapidsai#4646. This pull request is partly based on the work by @levsnv. Authors: - Andy Adinets (https://github.com/canonizer) Approvers: - Divye Gala (https://github.com/divyegala) - William Hicks (https://github.com/wphicks) URL: rapidsai#4648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T = floatfrom multi-sumchild_index()This is pull request 1 of 3 to integrate #4646. This pull request is partly based on the work by @levsnv.