float64 support in FIL core #4646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
CMake
conda
canonizer
changed the title
|
rerun tests |
|
@divyegala Thanks for your comments! I've addressed them, could you take another look? |
|
rerun tests |
dantegd
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #4646 +/- ##
===============================================
Coverage ? 84.06%
===============================================
Files ? 252
Lines ? 20336
Branches ? 0
===============================================
Hits ? 17095
Misses ? 3241
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
venkywonka
pushed a commit
to venkywonka/cuml
that referenced
this pull request
Apr 26, 2022
- removed default `T = float` from multi-sum - tests with float64 for multi-sum and `child_index()` - refactored multi-sum tests to reduce shared memory usage - this is needed for the tests with float64 to compile This is pull request 1 of 3 to integrate rapidsai#4646. This pull request is partly based on the work by @levsnv. Authors: - Andy Adinets (https://github.com/canonizer) Approvers: - Divye Gala (https://github.com/divyegala) - William Hicks (https://github.com/wphicks) URL: rapidsai#4648
venkywonka
pushed a commit
to venkywonka/cuml
that referenced
this pull request
Apr 26, 2022
Templatized functions related to FIL inference in preparation of `float64` support. Instantiations of templates with `float64`, or tests for `float64`, _are not included_; they will be provided in a future pull request. This is pull request 2 of 3 to integrate rapidsai#4646. This pull request is partly based on the work by @levsnv. Authors: - Andy Adinets (https://github.com/canonizer) - Levs Dolgovs (https://github.com/levsnv) - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Divye Gala (https://github.com/divyegala) - William Hicks (https://github.com/wphicks) URL: rapidsai#4655
venkywonka
pushed a commit
to venkywonka/cuml
that referenced
this pull request
Apr 26, 2022
`float64` support in FIL core and tests. Added `float64`-based instantiations of FIL types and functions, together with `float64`-based FIL tests. Treelite and Python layers _are not covered_ here, but will be in separate pull requests. This is pull request 3 of 3 to enable `float64` support in FIL core. This is partly based on the work by @levsnv. Authors: - Andy Adinets (https://github.com/canonizer) - Levs Dolgovs (https://github.com/levsnv) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#4646
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
- removed default `T = float` from multi-sum - tests with float64 for multi-sum and `child_index()` - refactored multi-sum tests to reduce shared memory usage - this is needed for the tests with float64 to compile This is pull request 1 of 3 to integrate rapidsai#4646. This pull request is partly based on the work by @levsnv. Authors: - Andy Adinets (https://github.com/canonizer) Approvers: - Divye Gala (https://github.com/divyegala) - William Hicks (https://github.com/wphicks) URL: rapidsai#4648
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Templatized functions related to FIL inference in preparation of `float64` support. Instantiations of templates with `float64`, or tests for `float64`, _are not included_; they will be provided in a future pull request. This is pull request 2 of 3 to integrate rapidsai#4646. This pull request is partly based on the work by @levsnv. Authors: - Andy Adinets (https://github.com/canonizer) - Levs Dolgovs (https://github.com/levsnv) - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Divye Gala (https://github.com/divyegala) - William Hicks (https://github.com/wphicks) URL: rapidsai#4655
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
`float64` support in FIL core and tests. Added `float64`-based instantiations of FIL types and functions, together with `float64`-based FIL tests. Treelite and Python layers _are not covered_ here, but will be in separate pull requests. This is pull request 3 of 3 to enable `float64` support in FIL core. This is partly based on the work by @levsnv. Authors: - Andy Adinets (https://github.com/canonizer) - Levs Dolgovs (https://github.com/levsnv) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#4646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
float64support in FIL core and tests.Added
float64-based instantiations of FIL types and functions, together withfloat64-based FIL tests.Treelite and Python layers are not covered here, but will be in separate pull requests.
This is pull request 3 of 3 to enable
float64support in FIL core. This is partly based on the work by @levsnv.