Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

float64 support in FIL functions #4655

Merged
merged 58 commits into from
Apr 2, 2022
Merged

float64 support in FIL functions #4655

merged 58 commits into from
Apr 2, 2022

Conversation

canonizer
Copy link
Contributor

Templatized functions related to FIL inference in preparation of float64 support.

Instantiations of templates with float64, or tests for float64, are not included; they will be provided in a future pull request.

This is pull request 2 of 3 to integrate #4646. This pull request is partly based on the work by @levsnv.

levsnv and others added 30 commits February 8, 2022 19:59
@levsnv
templatized node, forest and storage types
86bc6b5
@levsnv
compiles?
abfb605
@levsnv
Merge branch 'branch-22.04' of github.com:rapidsai/cuml into fp64
a5d970f
@levsnv
simplify leaf_output_t
96e2ae6
@levsnv
Merge branch 'branch-22.04' of github.com:rapidsai/cuml into fp64
ead832d
@levsnv
draft
35ad5d9
@levsnv
Merge branch 'branch-22.04' of github.com:rapidsai/cuml into fp64
df001e7
@levsnv
fixed extra/missing instantiations
f6efb88
@levsnv
Merge branch 'fp64' into func64
4bc4f99
@levsnv
style
1bebcca
@levsnv
style
aab158b
@levsnv
Merge branch 'fp64' into func64
c3f2d4f
@levsnv
removed ML::fil::init templatization, added KeyValuePair templatization
1236c52
@levsnv
style
cc946cd
@levsnv
add the old instantiations back
91ecb20
@levsnv
fixed
67f900e
@levsnv
style
c3c4deb
@canonizer
base_node::output() now compiles.
68e7f65
@canonizer
Merge branch 'branch-22.04' into dev-fil-fp64
fe2cf92
@canonizer
Fixed style.
b31069d
@canonizer
F -> real_t.
c250653
@canonizer
Small fixes.
2f658b5
@canonizer
Updated alignment.
6fb105b
@canonizer
static_assert(real_t == float) in a number of places.
f1a10be
@canonizer
noinline -> forceinline.
ce3624e
@canonizer
Updated comment.
63fadd1
@canonizer
Merge branch 'dev-fil-fp64' into enh-fil-func64
986a50d
@canonizer
Fixed many compiler errors.
fda7669
@canonizer
Multiple changes.
40f7a23
@canonizer
Fixed compilation errors; now it compiles.
12cc051
@canonizer canonizer requested a review from a team as a code owner March 28, 2022 20:25
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 28, 2022
@canonizer
Copy link
Contributor Author

Please ignore python/cuml/decomposition/{pca_mg.pyx,tsvd_mg.pyx,utils.pxd,utils_mg.pxd}; I've added them from #4645 to get Python wrapper compile.

@canonizer
Copy link
Contributor Author

@wphicks @divyegala I've addressed all of your comments, and also templatized methods and types in fil.h as we discussed. Could you take another look?

Please ignore the files in python/cuml/decomposition; they come from #4645, and are only necessary to fix Cython build errors.

divyegala
divyegala approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@canonizer canonizer changed the base branch from branch-22.04 to branch-22.06 March 29, 2022 23:03
wphicks
wphicks reviewed Mar 30, 2022
View reviewed changes
cpp/src/fil/infer.cu Outdated Show resolved Hide resolved
v22.06 Release automation moved this from PR-Needs review to PR-Reviewer approved Mar 30, 2022
@wphicks wphicks added the non-breaking Non-breaking change label Mar 30, 2022
@canonizer
Copy link
Contributor Author

rerun tests

@canonizer
Copy link
Contributor Author

rerun tests

1 similar comment
@dantegd
Copy link
Member

dantegd commented Apr 2, 2022

rerun tests

@dantegd dantegd added the feature request New feature or request label Apr 2, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@257a99c). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.06    #4655   +/-   ##
===============================================
  Coverage                ?   83.97%           
===============================================
  Files                   ?      252           
  Lines                   ?    20336           
  Branches                ?        0           
===============================================
  Hits                    ?    17078           
  Misses                  ?     3258           
  Partials                ?        0
Flag Coverage Δ
dask 44.98% <0.00%> (?)
non-dask 77.26% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 257a99c...1b864b6. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Apr 2, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4ee12db into rapidsai:branch-22.06 Apr 2, 2022
v22.06 Release automation moved this from PR-Reviewer approved to Done Apr 2, 2022
@canonizer canonizer mentioned this pull request Apr 13, 2022
Merged
venkywonka pushed a commit to venkywonka/cuml that referenced this pull request Apr 26, 2022
@canonizer @venkywonka
float64 support in FIL functions (rapidsai#4655)
a3ea64d 
Templatized functions related to FIL inference in preparation of `float64` support.

Instantiations of templates with `float64`, or tests for `float64`, _are not included_; they will be provided in a future pull request.

This is pull request 2 of 3 to integrate rapidsai#4646. This pull request is partly based on the work by @levsnv.

Authors:
  - Andy Adinets (https://github.com/canonizer)
  - Levs Dolgovs (https://github.com/levsnv)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - William Hicks (https://github.com/wphicks)

URL: rapidsai#4655
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@canonizer
float64 support in FIL functions (rapidsai#4655)
3ce72e6 
Templatized functions related to FIL inference in preparation of `float64` support.

Instantiations of templates with `float64`, or tests for `float64`, _are not included_; they will be provided in a future pull request.

This is pull request 2 of 3 to integrate rapidsai#4646. This pull request is partly based on the work by @levsnv.

Authors:
  - Andy Adinets (https://github.com/canonizer)
  - Levs Dolgovs (https://github.com/levsnv)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - William Hicks (https://github.com/wphicks)

URL: rapidsai#4655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
CUDA/C++ Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
v22.06 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@canonizer @dantegd @codecov-commenter @wphicks @divyegala @levsnv