Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate adj_to_csr implementation #4829

Merged

Conversation

ahendriksen
Copy link
Contributor

This functionality has been moved to RAFT.

@ahendriksen ahendriksen requested a review from a team as a code owner July 25, 2022 09:51
@ahendriksen ahendriksen added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 25, 2022
@ahendriksen
Copy link
Contributor Author

This is a follow up to #4803

Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Allard for the PR! Please fix the style error, otherwise the PR looks good to me.

This functionality has been moved to RAFT.
@ahendriksen ahendriksen force-pushed the enh-remove-duplicate-adj-to-csr branch from dbec261 to 0b4142a Compare July 25, 2022 13:13
@caryr35 caryr35 added this to PR-WIP in v22.08 Release via automation Jul 25, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.08 Release Jul 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4829 (0b4142a) into branch-22.08 (2fad4c0) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.08    #4829   +/-   ##
=============================================
  Coverage         77.62%   77.62%           
=============================================
  Files               180      180           
  Lines             11384    11384           
=============================================
  Hits               8837     8837           
  Misses             2547     2547           
Flag Coverage Δ
dask 45.52% <ø> (ø)
non-dask 67.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fad4c0...0b4142a. Read the comment docs.

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @ahendriksen!

v22.08 Release automation moved this from PR-Needs review to PR-Reviewer approved Jul 25, 2022
@cjnolet
Copy link
Member

cjnolet commented Jul 25, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 092c4de into rapidsai:branch-22.08 Jul 25, 2022
v22.08 Release automation moved this from PR-Reviewer approved to Done Jul 25, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
This functionality has been moved to RAFT.

Authors:
  - Allard Hendriksen (https://github.com/ahendriksen)

Approvers:
  - Tamas Bela Feher (https://github.com/tfeher)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants