Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating python to use pylibraft #4887

Merged
merged 15 commits into from Sep 21, 2022
Merged

Updating python to use pylibraft #4887

merged 15 commits into from Sep 21, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Sep 13, 2022 •
edited

This is a fairly sizable PR but it needs to be done before the 22.10 release as pyraft will not longer be released.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 13, 2022
@cjnolet cjnolet added this to PR-WIP in v22.10 Release via automation Sep 13, 2022
@cjnolet cjnolet requested review from a team as code owners September 13, 2022 14:40
@github-actions github-actions bot added CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue labels Sep 13, 2022
@github-actions github-actions bot added gpuCI gpuCI issue and removed CMake CUDA/C++ labels Sep 14, 2022
@cjnolet cjnolet requested a review from a team as a code owner September 15, 2022 01:55
@cjnolet
Copy link
Member Author

cjnolet commented Sep 15, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Sep 19, 2022

Noticed this in the CI log:

-- Using src='https://github.com/rapidsai/rapids-cmake/archive/refs/heads/branch-22.10.zip'
CMake Error at rapids-cmake-subbuild/rapids-cmake-populate-prefix/src/rapids-cmake-populate-stamp/download-rapids-cmake-populate.cmake:170 (message):
  Each download failed!

    error: downloading 'https://github.com/rapidsai/rapids-cmake/archive/refs/heads/branch-22.10.zip' failed
          status_code: 35
          status_string: "SSL connect error"
          log:
          --- LOG BEGIN ---
            Trying 192.30.255.112:443...

  Connected to github.com (192.30.255.112) port 443 (#0)

  ALPN: offers h2

  ALPN: offers http/1.1

  [5 bytes data]

  TLSv1.3 (OUT), TLS handshake, Client hello (1):

  [512 bytes data]

  OpenSSL SSL_connect: Connection reset by peer in connection to
  github.com:443

  Closing connection 0

  

          --- LOG END ---
          
    


FAILED: rapids-cmake-populate-prefix/src/rapids-cmake-populate-stamp/rapids-cmake-populate-download /workspace/cpp/build/_deps/rapids-cmake-subbuild/rapids-cmake-populate-prefix/src/rapids-cmake-populate-stamp/rapids-cmake-populate-download 
cd /workspace/cpp/build/_deps && /opt/conda/envs/rapids/bin/cmake -P /workspace/cpp/build/_deps/rapids-cmake-subbuild/rapids-cmake-populate-prefix/src/rapids-cmake-populate-stamp/download-rapids-cmake-populate.cmake && /opt/conda/envs/rapids/bin/cmake -P /workspace/cpp/build/_deps/rapids-cmake-subbuild/rapids-cmake-populate-prefix/src/rapids-cmake-populate-stamp/verify-rapids-cmake-populate.cmake && /opt/conda/envs/rapids/bin/cmake -P /workspace/cpp/build/_deps/rapids-cmake-subbuild/rapids-cmake-populate-prefix/src/rapids-cmake-populate-stamp/extract-rapids-cmake-populate.cmake && /opt/conda/envs/rapids/bin/cmake -E touch /workspace/cpp/build/_deps/rapids-cmake-subbuild/rapids-cmake-populate-prefix/src/rapids-cmake-populate-stamp/rapids-cmake-populate-download
ninja: build stopped: subcommand failed.

CMake Error at /opt/conda/envs/rapids/share/cmake-3.24/Modules/FetchContent.cmake:1604 (message):
  Build step for rapids-cmake failed: 1
Call Stack (most recent call first):
  /opt/conda/envs/rapids/share/cmake-3.24/Modules/FetchContent.cmake:1744:EVAL:2 (__FetchContent_directPopulate)
  /opt/conda/envs/rapids/share/cmake-3.24/Modules/FetchContent.cmake:1744 (cmake_language)
  /opt/conda/envs/rapids/share/cmake-3.24/Modules/FetchContent.cmake:1958 (FetchContent_Populate)
  build/CUML_RAPIDS.cmake:72 (FetchContent_MakeAvailable)
  /workspace/fetch_rapids.cmake:19 (include)
  CMakeLists.txt:19 (include)


-- Configuring incomplete, errors occurred!

Going to try and re-run the tests.

@cjnolet
Copy link
Member Author

cjnolet commented Sep 19, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Sep 20, 2022

rerun tests

@cjnolet cjnolet mentioned this pull request Sep 20, 2022
Open
msadang
msadang approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

v22.10 Release automation moved this from PR-WIP to PR-Reviewer approved Sep 20, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Sep 21, 2022

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Sep 21, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Sep 21, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

Base: 78.02% // Head: 79.54% // Increases project coverage by +1.52% 🎉

Coverage data is based on head (26236f7) compared to base (7a0ab85).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-22.10    #4887      +/-   ##
================================================
+ Coverage         78.02%   79.54%   +1.52%     
================================================
  Files               180      180              
  Lines             11385    11486     +101     
================================================
+ Hits               8883     9137     +254     
+ Misses             2502     2349     -153
Flag Coverage Δ
dask 46.15% <ø> (-0.07%) ⬇️
non-dask 68.89% <ø> (+1.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/neighbors/kernel_density.py 80.26% <0.00%> (-7.24%) ⬇️
python/cuml/common/array.py 95.10% <0.00%> (-2.88%) ⬇️
python/cuml/cluster/__init__.py 100.00% <0.00%> (ø)
python/cuml/metrics/__init__.py 100.00% <0.00%> (ø)
python/cuml/preprocessing/__init__.py 100.00% <0.00%> (ø)
python/cuml/benchmark/automated/utils/utils.py 0.00% <0.00%> (ø)
python/cuml/dask/preprocessing/LabelEncoder.py 93.33% <0.00%> (ø)
...cuml/_thirdparty/sklearn/preprocessing/__init__.py 100.00% <0.00%> (ø)
python/cuml/thirdparty_adapters/adapters.py 91.54% <0.00%> (+0.05%) ⬆️
...cuml/_thirdparty/sklearn/utils/skl_dependencies.py 57.64% <0.00%> (+0.50%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet
Copy link
Member Author

cjnolet commented Sep 21, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8942c3f into rapidsai:branch-22.10 Sep 21, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Sep 21, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@cjnolet
Updating python to use pylibraft (rapidsai#4887)
50e9cad 
This is a fairly sizable PR but it needs to be done before the `22.10` release as `pyraft` will not longer be released.

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Mark Sadang (https://github.com/msadang)

URL: rapidsai#4887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@msadang msadang msadang approved these changes

Assignees
No one assigned
Labels
conda conda issue CUDA/C++ Cython / Python Cython or Python issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.10 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cjnolet @codecov-commenter @dantegd @msadang