Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rapdsi_cpm_find(COMPONENTS ) for proper component tracking #4989

Merged

Conversation

robertmaynard
Copy link
Contributor

This allows rapids-cmake to generate the correct find_dependency(raft COMPONENTS ...) required to use cuml

This allows rapids-cmake to generate the correct
find_dependency(raft COMPONENTS ...) required to use
cuml
@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Nov 9, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner November 9, 2022 19:09
@robertmaynard robertmaynard added this to PR-WIP in v22.12 Release via automation Nov 9, 2022
@cjnolet
Copy link
Member

cjnolet commented Nov 10, 2022

This should pass after #4990 is merged.

@cjnolet
Copy link
Member

cjnolet commented Nov 10, 2022

rerun tests

v22.12 Release automation moved this from PR-WIP to PR-Reviewer approved Nov 10, 2022
@robertmaynard
Copy link
Contributor Author

@cjnolet Okay to merge?

@cjnolet
Copy link
Member

cjnolet commented Nov 14, 2022

@robertmaynard yep, this is okay to merge!

@cjnolet
Copy link
Member

cjnolet commented Nov 14, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6500897 into rapidsai:branch-22.12 Nov 14, 2022
v22.12 Release automation moved this from PR-Reviewer approved to Done Nov 14, 2022
@robertmaynard robertmaynard deleted the use_cpm_find_components branch November 14, 2022 15:20
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
…sai#4989)

This allows rapids-cmake to generate the correct find_dependency(raft COMPONENTS ...) required to use cuml

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CUDA/C++ non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants