Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifying cusparse wrapper revert passes CI #4990

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Nov 10, 2022

No description provided.

@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Nov 10, 2022
@cjnolet cjnolet requested review from a team as code owners November 10, 2022 11:40
@cjnolet cjnolet added this to PR-WIP in v22.12 Release via automation Nov 10, 2022
@github-actions github-actions bot added CMake CUDA/C++ Cython / Python Cython or Python issue labels Nov 10, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Nov 10, 2022

After talking w/ @robertmaynard, we're just going to merge this PR as-is and not bother actually merging the revert on the raft side. That way the cuml side can be fixed (and the raft side if needed) and we can just revert the pinned raft tag.

v22.12 Release automation moved this from PR-WIP to PR-Reviewer approved Nov 10, 2022
@wphicks
Copy link
Contributor

wphicks commented Nov 10, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@496f1f1). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.12    #4990   +/-   ##
===============================================
  Coverage                ?   79.52%           
===============================================
  Files                   ?      183           
  Lines                   ?    11655           
  Branches                ?        0           
===============================================
  Hits                    ?     9269           
  Misses                  ?     2386           
  Partials                ?        0           
Flag Coverage Δ
dask 46.10% <0.00%> (?)
non-dask 69.02% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rapids-bot rapids-bot bot merged commit f0bb485 into rapidsai:branch-22.12 Nov 10, 2022
v22.12 Release automation moved this from PR-Reviewer approved to Done Nov 10, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake CUDA/C++ Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants